Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-events-targets): Add DLQ Support for EventBus Target #15954

Closed
2 tasks
canpan14 opened this issue Aug 9, 2021 · 2 comments · Fixed by #16383
Closed
2 tasks

(aws-events-targets): Add DLQ Support for EventBus Target #15954

canpan14 opened this issue Aug 9, 2021 · 2 comments · Fixed by #16383
Labels
@aws-cdk/aws-events-targets effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@canpan14
Copy link

canpan14 commented Aug 9, 2021

DLQ Support was added for most targets, but not for EventBus. I'm not sure if this was an oversight or wasn't possible at the time.

This is an available feature through the AWS Console already.

Use Case

Make it possible to attach DLQ to EventBus targets without the use of the AWS Console following the same strategy that other Targets have available to them.

Proposed Solution

import * as sqs from "@aws-cdk/aws-sqs";
import {EventBus, Rule} from '@aws-cdk/aws-events';
import {EventBus as EventBusTarget} from '@aws-cdk/aws-events-targets';

const myDeadLetterQueue = new sqs.Queue(this, 'Queue');

const myEventBus = new EventBus(this, 'EventBus', {
  eventBusName: 'someName',
});

const myRule = new Rule(this, 'myRule', {
  myEventBus,
  eventPattern: {
    detailType: ['detailType'],
  },
});

const someOtherEventBus = EventBus.fromEventBusArn(this, 'otherEventBus', 'otherEventBusArn);

// Currently deadLetterQueue is not an option
myRule.addTarget(new EventBusTarget(someOtherEventBus, {
  deadLetterQueue: myDeadLetterQueue
}));

Other

Associated Issue: #11612

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@canpan14 canpan14 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 9, 2021
@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Aug 10, 2021
@rix0rrr rix0rrr removed their assignment Aug 10, 2021
@nirweiner2
Copy link

I would love to have this issue solved as well.
Following...

@mergify mergify bot closed this as completed in #16383 Oct 27, 2021
mergify bot pushed a commit that referenced this issue Oct 27, 2021
Closes #15954.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
Closes aws#15954.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-events-targets effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants