-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(log): New ResourcePolicy construct not exported from index.js #17402
Labels
@aws-cdk/aws-logs
Related to Amazon CloudWatch Logs
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
p1
Comments
matthias-pichler
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
Nov 8, 2021
Hey @matthias-pichler-warrify 👋🏻 Thanks for bringing this to our attention. PR here: #17403 |
ryparker
added
effort/small
Small work item – less than a day of effort
p1
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Nov 8, 2021
mergify bot
pushed a commit
that referenced
this issue
Nov 9, 2021
…17403) ## Summary This PR modifies the aws-logs `index.ts` file to also forward the exports from `policy.ts` ([a newly created file](#17015) that implements the `ResourcePolicy` class). Fixes: #17402 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this issue
Feb 21, 2022
…ws#17403) ## Summary This PR modifies the aws-logs `index.ts` file to also forward the exports from `policy.ts` ([a newly created file](aws#17015) that implements the `ResourcePolicy` class). Fixes: aws#17402 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-logs
Related to Amazon CloudWatch Logs
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
p1
What is the problem?
when importing
fails with something like:
logs
does not have propertyResourcePolicy
And indeed when inspecting the PR that added it the
lib/index.ts
file wasn't updated with the new exportReproduction Steps
What did you expect to happen?
The new construct should be export just like others
What actually happened?
The export was forgotten
CDK CLI Version
1.131.0
Framework Version
1.131.0
Node.js Version
16.9.0
OS
macOS
Language
Typescript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: