-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(assert-internal): stringLike function does not support multiline strings #17691
Labels
@aws-cdk/aws-lambda
Related to AWS Lambda
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
p2
Comments
diegotry
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
Nov 24, 2021
diegotry
changed the title
(cdk-assert): stringLike function does not support multiline strings
(assert-internal): stringLike function does not support multiline strings
Nov 24, 2021
peterwoodworth
added
effort/small
Small work item – less than a day of effort
p2
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Nov 24, 2021
mergify bot
pushed a commit
that referenced
this issue
Nov 25, 2021
Updates the `RegExp` constructor to support multiline. Resolves #17691 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
beezly
pushed a commit
to beezly/aws-cdk
that referenced
this issue
Nov 29, 2021
Updates the `RegExp` constructor to support multiline. Resolves aws#17691 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this issue
Feb 21, 2022
Updates the `RegExp` constructor to support multiline. Resolves aws#17691 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-lambda
Related to AWS Lambda
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
p2
What is the problem?
I am writing an unit test using the stringLike() as suggested by @nija-at @ #16827
The value being checked contains line breaks (\n) which fails on current implementation of stringLike()
Reproduction Steps
Copied the code from the aws-cdk:
output is "false"
What did you expect to happen?
to return
true
What actually happened?
it returned false
CDK CLI Version
1.134.0
Framework Version
No response
Node.js Version
12
OS
mac
Language
Typescript
Language Version
No response
Other information
Issue can be fixed by:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/multiline
I am going to submit a PR soon.
The text was updated successfully, but these errors were encountered: