Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(glue): remove batchDeletePartition from grantRead() permissions #17941

Merged
merged 2 commits into from
Dec 10, 2021
Merged

fix(glue): remove batchDeletePartition from grantRead() permissions #17941

merged 2 commits into from
Dec 10, 2021

Conversation

kaizencc
Copy link
Contributor

It is convention in the CDK to expose the underlying grant() API to make it simple for users to grant custom permissions to their resource.

In addition, this PR removes 'glue:BatchDeletePartition' from readPermissions, which was previously erroneously added.

closes #17935 and #15116.

BREAKING CHANGE: the grantRead API previously included 'glue:BatchDeletePartition', and now it does not.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 10, 2021

@github-actions github-actions bot added the @aws-cdk/aws-glue Related to AWS Glue label Dec 10, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 10, 2021
@kaizencc kaizencc changed the title feat(glue): expose grant API fix(glue): remove batchDeletePartition from grantRead() permissions Dec 10, 2021
@kaizencc
Copy link
Contributor Author

renamed to the fix because I feel like that is more important to communicate to users.

@kaizencc kaizencc requested a review from a team December 10, 2021 16:48
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c9b530b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3d64f9b into aws:master Dec 10, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 10, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@kaizencc kaizencc deleted the gluegrant branch December 10, 2021 18:51
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…ns (aws#17941)

It is convention in the CDK to expose the underlying `grant()` API to make it simple for users to grant custom permissions to their resource. 

In addition, this PR removes 'glue:BatchDeletePartition' from `readPermissions`, which was previously erroneously added.

closes aws#17935 and aws#15116.

BREAKING CHANGE: the grantRead API previously included 'glue:BatchDeletePartition', and now it does not.


 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-glue Related to AWS Glue contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-glue): expose grant API for glue Table
3 participants