You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple routes are defined for a single lambda integration, only one of
the routes gets permission to execute the function. This is because the
permissions are added when the integration is bound to the route, which happens
only once per integration.
Split the _bindToRoute workflow into two parts:
The actual bind, followed by the creation of an HttpIntegration. We keep
doing this only once per integration.
A post-bind step, that happens for every route.
In the case of HttpLambdaIntegration, adding the permission has been moved to
the post bind step. All other integrations remain the same.
Will this work for WebSocketApi and WebSocketRouteOptions/aws_apigatewayv2_integrations.WebSocketLambdaIntegration as well? I am not familiar enough with the code to determine that... I just spent several hours trying to figure out why my $disconnect and $default routes were inaccessible (having defined them with the same integration pointing to the same lambda function), so just trying to help out :)
Will this work for WebSocketApi and WebSocketRouteOptions/aws_apigatewayv2_integrations.WebSocketLambdaIntegration as well? I am not familiar enough with the code to determine that... I just spent several hours trying to figure out why my $disconnect and $default routes were inaccessible (having defined them with the same integration pointing to the same lambda function), so just trying to help out :)
No, this is specific to HttpApi. But that's a good reminder to look at the situation with WebSocketApi.
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
…execute permission is created (aws#18716)
When multiple routes are defined for a single lambda integration, only one of
the routes gets permission to execute the function. This is because the
permissions are added when the integration is bound to the route, which happens
only once per integration.
Split the `_bindToRoute` workflow into two parts:
1. The actual bind, followed by the creation of an `HttpIntegration`. We keep
doing this only once per integration.
2. A post-bind step, that happens for every route.
In the case of `HttpLambdaIntegration`, adding the permission has been moved to
the post bind step. All other integrations remain the same.
Fixesaws#18201.
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
the
@aws-cdk/aws-apigatewayv2-integrations
When multiple routes are defined for a single lambda integration, only one of
the routes gets permission to execute the function. This is because the
permissions are added when the integration is bound to the route, which happens
only once per integration.
Split the
_bindToRouteworkflow into two parts:HttpIntegration. We keepdoing this only once per integration.
In the case of
HttpLambdaIntegration, adding the permission has been moved tothe post bind step. All other integrations remain the same.
Fixes #18201.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license