Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(batch): add launchTemplateId in LaunchTemplateSpecification #20184

Merged
merged 9 commits into from
Jul 7, 2022
Merged

feat(batch): add launchTemplateId in LaunchTemplateSpecification #20184

merged 9 commits into from
Jul 7, 2022

Conversation

robertd
Copy link
Contributor

@robertd robertd commented May 3, 2022

Closes #20163

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 3, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team May 3, 2022 06:09
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 labels May 3, 2022
@robertd
Copy link
Contributor Author

robertd commented May 3, 2022

cc @madeline-k based on gitbot assignment of the #20163 issue

@TheRealAmazonKendra TheRealAmazonKendra changed the base branch from v1-main to main June 2, 2022 18:25
comcalvi
comcalvi previously approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

kaizencc
kaizencc reviewed Jun 29, 2022
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few nits here... will edit myself

packages/@aws-cdk/aws-batch/lib/compute-environment.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-batch/lib/compute-environment.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-batch/README.md Show resolved Hide resolved
@mergify mergify bot dismissed comcalvi’s stale review June 29, 2022 11:11

Pull request has been modified.

kaizencc
kaizencc previously approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And now approved :)

@mergify
Copy link
Contributor

mergify bot commented Jun 29, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@robertd
Copy link
Contributor Author

robertd commented Jun 30, 2022 •
edited
Loading

@kaizencc Thanks for stepping in with the updates. However, is this PR stuck now in CI/CD?

@mergify mergify bot dismissed kaizencc’s stale review July 7, 2022 14:57

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b867e80
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 269b8d0 into aws:main Jul 7, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@robertd robertd deleted the robertd/batch branch July 8, 2022 16:40
@robertd
Copy link
Contributor Author

robertd commented Jul 8, 2022

TY @kaizencc

daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
@robertd @daschaa
feat(batch): add launchTemplateId in LaunchTemplateSpecification (aws…
d915732 
…#20184)

Closes aws#20163

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https:/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https:/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https:/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc approved these changes

@comcalvi comcalvi comcalvi left review comments

Assignees

@TheRealAmazonKendra TheRealAmazonKendra

Labels
feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[aws-batch] missing launchTemplateId in LaunchTemplateSpecification
5 participants
@robertd @aws-cdk-automation @kaizencc @comcalvi @TheRealAmazonKendra