fix(integ-runner): test names change depending on the discovery directory #21093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tory The name of the test that is stored in the `integ.json` file for legacy test cases changes depending on what directory you run the test from. For example, if you were to run the below command from the root of the project the test name would be `@aws-cdk/aws-lambda/test/integ.assets.file` `yarn integ-runner --directory package/@aws-cdk/aws-lambda test/integ.assets.file.js` If you were to run this command from the `packages/@aws-cdk/aws-lambda` directory then the test name would be `integ.assets.file` `yarn integ integ.assets.file.js` This PR attempts to normalize the test name by using the name of the integration test file, minus the file extension. **Note, this only affects legacy test cases. The new style test cases have a different mechanism to generate a test name. I will create a follow up PR to update all of the `integ.json` files for all of the existing test cases to have the normalized name.
|
|
TheRealAmazonKendra
approved these changes
Jul 12, 2022
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jul 14, 2022
This PR is a follow up to #21093 which updated the logic to normalize the name of the integration test that was stored in the `integ.json` file. This PR updates the names in all of the `integ.json` files. This will cut down on some of the noise/confusion in PRs. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https:/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https:/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https:/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
guessi
pushed a commit
to guessi/aws-cdk
that referenced
this pull request
Jul 17, 2022
This PR is a follow up to aws#21093 which updated the logic to normalize the name of the integration test that was stored in the `integ.json` file. This PR updates the names in all of the `integ.json` files. This will cut down on some of the noise/confusion in PRs. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https:/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https:/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https:/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
comcalvi
pushed a commit
to comcalvi/aws-cdk
that referenced
this pull request
Jul 25, 2022
This PR is a follow up to aws#21093 which updated the logic to normalize the name of the integration test that was stored in the `integ.json` file. This PR updates the names in all of the `integ.json` files. This will cut down on some of the noise/confusion in PRs. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https:/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https:/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https:/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of the test that is stored in the
integ.jsonfile for legacytest cases changes depending on what directory you run the test from.
For example, if you were to run the below command from the root of the
project the test name would be
@aws-cdk/aws-lambda/test/integ.assets.fileyarn integ-runner --directory package/@aws-cdk/aws-lambda test/integ.assets.file.jsIf you were to run this command from the
packages/@aws-cdk/aws-lambdadirectory then the test name would be
integ.assets.fileyarn integ integ.assets.file.jsThis PR attempts to normalize the test name by using the name of the
integration test file, minus the file extension.
**Note, this only affects legacy test cases. The new style test cases
have a different mechanism to generate a test name.
I will create a follow up PR to update all of the
integ.jsonfiles forall of the existing test cases to have the normalized name.
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license