-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(cfnspec): Unable to run bump-cfnspec.sh
due to AWS::DynamoDB::Table
changes
#21957
Comments
Thanks for letting us know about this, we're aware of it and have been working with CloudFormation to have a spec release which doesn't break the build 🙂 I'm going to close this because we're tracking it internally and I don't want this to stick around in our backlog, but thanks a ton for looking out for this @kylelaker it's much appreciated |
|
Describe the bug
There has not been an update to
cfnspec
in a few weeks. The current spec version is v87.0.0. The latest version in the AWS CDK repo is v85.0.0.Running
./scripts/bump-cfnspec.sh
results in an error:Expected Behavior
Running
./scripts/bump-cfnspec.sh
should properly apply the latest version of the CloudFormation Resource Specification.Current Behavior
The
./scripts/bump-cfnspec.sh
script fails with the following error messageFull error message
Reproduction Steps
yarn install
./scripts/bump-cfnspec.sh
Possible Solution
The update causing the complaint in
AWS::DynamoDB::Table
is not covered by the switch statement ataws-cdk/packages/@aws-cdk/cfnspec/build-tools/spec-diff.ts
Lines 94 to 116 in aedc888
Either additional cases may need to be added, something to prevent entering the
switch
, orError
to not be thrown.Additional Information/Context
This looks like the same sort of thing that resulted in #12920.
Full diff of DynamoDB service resources
CDK CLI Version
main
branchFramework Version
No response
Node.js Version
v16.15.0
OS
Linux
Language
Typescript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: