Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-cdk: make "cdk notices" show only unacknowledged notices #23078

Closed
2 tasks
enummela-diligent opened this issue Nov 24, 2022 · 2 comments · Fixed by #31250
Closed
2 tasks

aws-cdk: make "cdk notices" show only unacknowledged notices #23078

enummela-diligent opened this issue Nov 24, 2022 · 2 comments · Fixed by #31250
Labels
@aws-cdk/core Related to core CDK functionality cli Issues related to the CDK CLI effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@enummela-diligent
Copy link

enummela-diligent commented Nov 24, 2022

Describe the feature

Make it possible for cdk notices to show only the unacknowledged notices. Currently it lists "the notices that are relevant to the current CDK repository, regardless of context flags or notices that have been acknowledged" [link].

Use Case

Checking if there are any unacknowledged notices in CI checks. Example package.json:

{
  "scripts": {
    "test": "jest",
    "notices": "notices=$(cdk notices --unacknowledged-only); [ -z \"$notices\" ]",
    "ci": "npm test && npm run notices"
  }
}

Proposed Solution

One possible way to implement could be adding an --unacknowledged-only flag.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.50.0 (build 4c11af6)

Environment details (OS name and version, etc.)

macOS Monterey 12.6.1

@enummela-diligent enummela-diligent added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 24, 2022
@peterwoodworth peterwoodworth added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Nov 26, 2022
@peterwoodworth peterwoodworth removed their assignment Nov 26, 2022
@peterwoodworth
Copy link
Contributor

Thanks for this request, it would be nice if we supported this 🙂

I am marking this issue as p2, which means that we are unable to work on this immediately.

We use +1s to help prioritize our work, and are happy to revaluate this issue based on community feedback. You can reach out to the cdk.dev community on Slack to solicit support for reprioritization.

Check out our contributing guide if you're interested in contributing yourself - there's a low chance the team will be able to address this soon but we'd be happy to review a PR 🙂

@khushail khushail added @aws-cdk/core Related to core CDK functionality cli Issues related to the CDK CLI labels Jun 5, 2024
@mergify mergify bot closed this as completed in #31250 Sep 4, 2024
mergify bot pushed a commit that referenced this issue Sep 4, 2024
### Issue # (if applicable)

Closes #23078

### Reason for this change

`cdk notices` will show all the notices the cdk version is affected by.
The additional command `cdk notices --unacknowledged` will show the notices the customer hasn't acknowledge with `cdk acknowledge <NUMBER>`.

The output will display the number of unacknowledged notices, with the following line as the last statement:
`There are <NUMBER> unacknowledged notice(s).`
Customer or automation tools can use this command to filter for the number of unacknowledged notices.


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https:/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https:/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Copy link

github-actions bot commented Sep 4, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2024
pahud pushed a commit to pahud/aws-cdk that referenced this issue Sep 9, 2024
### Issue # (if applicable)

Closes aws#23078

### Reason for this change

`cdk notices` will show all the notices the cdk version is affected by.
The additional command `cdk notices --unacknowledged` will show the notices the customer hasn't acknowledge with `cdk acknowledge <NUMBER>`.

The output will display the number of unacknowledged notices, with the following line as the last statement:
`There are <NUMBER> unacknowledged notice(s).`
Customer or automation tools can use this command to filter for the number of unacknowledged notices.


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https:/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https:/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
xazhao pushed a commit to xazhao/aws-cdk that referenced this issue Sep 12, 2024
### Issue # (if applicable)

Closes aws#23078

### Reason for this change

`cdk notices` will show all the notices the cdk version is affected by.
The additional command `cdk notices --unacknowledged` will show the notices the customer hasn't acknowledge with `cdk acknowledge <NUMBER>`.

The output will display the number of unacknowledged notices, with the following line as the last statement:
`There are <NUMBER> unacknowledged notice(s).`
Customer or automation tools can use this command to filter for the number of unacknowledged notices.


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https:/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https:/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
GavinZZ pushed a commit that referenced this issue Sep 12, 2024
### Issue # (if applicable)

Closes #23078

### Reason for this change

`cdk notices` will show all the notices the cdk version is affected by.
The additional command `cdk notices --unacknowledged` will show the notices the customer hasn't acknowledge with `cdk acknowledge <NUMBER>`.

The output will display the number of unacknowledged notices, with the following line as the last statement:
`There are <NUMBER> unacknowledged notice(s).`
Customer or automation tools can use this command to filter for the number of unacknowledged notices.


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https:/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https:/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/core Related to core CDK functionality cli Issues related to the CDK CLI effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants