Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sagemaker: Make IEndpointConfig property of Endpoint optional #23162

Open
1 of 2 tasks
petermeansrock opened this issue Nov 29, 2022 · 0 comments
Open
1 of 2 tasks

sagemaker: Make IEndpointConfig property of Endpoint optional #23162

petermeansrock opened this issue Nov 29, 2022 · 0 comments
Labels
@aws-cdk/aws-sagemaker Related to AWS SageMaker effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3

Comments

@petermeansrock
Copy link
Contributor

petermeansrock commented Nov 29, 2022

Describe the feature

Even though explicitly defining an EndpointConfig resource allows for reusable configuration across endpoints, as discussed on the original Endpoint L2 construct PR, customers looking to deploy a single endpoint may find it easier to have the endpoint configuration encapsulated within the endpoint construct.

Please 👍 this issue to help with the prioritization of this feature.

Use Case

Customers may not want to have to define their own IEndpointConfig resource, instead relying on Endpoint to instantiate one for them (in the event they don't provide one on EndpointProps).

Proposed Solution

Add each of these members of EndpointConfigProps to EndpointProps as optional arguments (while making the existing IEndpointConfig prop value optional as well) while ensuring that the IEndpointConfig property and the new members are mutually exclusive.

In this scenario, it likely also make sense to include an addInstanceProductionVariant on Endpoint so that customers can mutate the backing EndpointConfig in the same manner as they could using their own instance (this does have the added bonus of returning an IEndpointInstanceProductionVariant instance from the method, eliminating the need for customers to look up the variant by name).

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.54.0-alpha.0

Environment details (OS name and version, etc.)

macOS Ventura

@petermeansrock petermeansrock added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 29, 2022
@github-actions github-actions bot added the @aws-cdk/aws-sagemaker Related to AWS SageMaker label Nov 29, 2022
@peterwoodworth peterwoodworth added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Nov 29, 2022
@pahud pahud added p3 and removed p2 labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-sagemaker Related to AWS SageMaker effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3
Projects
None yet
Development

No branches or pull requests

4 participants