aws-s3-deployment: Wrong URL in BucketDeployment.deployedBucket.bucketWebsiteUrl

[iwasinnam]

Describe the bug

I deploy a static website using s3 deployment, and print the endpoint from BucketDeployment.deployedBucket.bucketWebsiteUrl. When deploying to Frankfurt region the URL I get http://my-sweet-stack-123456789-xxxxxxxxxx.s3-website-eu-central-1.amazonaws.com/

That is, the URL I received has a hyphen before the region name, but the actual endpoint is actually with a dot (...s3-website.eu-central-1...)

Expected Behavior

The actual URL is http://my-sweet-stack-123456789-xxxxxxxxxx.s3-website.eu-central-1.amazonaws.com/

As is indeed documented here: Amazon S3 website endpoints

Current Behavior

The URL in BucketDeployment.deployedBucket.bucketWebsiteUrl is wrong and leads nowhere.

Reproduction Steps

1. Deploy a static website to eu-central-1 region
2. Print .deployedBucket.bucketWebsiteUrl of the bucket you just deployed
3. Compare to the URL that appears in the console of S3 (bucket -> Properties -> Static web hosting)
4. They're different!

Possible Solution

If had to guess I'd say that either there's a typo in the table that maps regions to static hosting endpoint URL format, or there is no such table.

Additional Information/Context

No response

CDK CLI Version

2.54.0 (build 9f41881)

Framework Version

No response

Node.js Version

v12.22.9

OS

Ubuntu 22.04.1

Language

Typescript

Language Version

No response

Other information

No response

[peterwoodworth]

When we return the deployedBucket prop, we are returning the following:

aws-cdk/packages/@aws-cdk/aws-s3-deployment/lib/bucket-deployment.ts

Lines 463 to 467 in 1485f48

	public get deployedBucket(): s3.IBucket {
	this.requestDestinationArn = true;
	this._deployedBucket = this._deployedBucket ?? s3.Bucket.fromBucketArn(this, 'DestinationBucket', cdk.Token.asString(this.cr.getAtt('DestinationBucketArn')));
	return this._deployedBucket;
	}

I can't see anywhere else where we are setting _deployedBucket, so this should always return an import Bucket.fromBucketArn

fromBucketArn will call fromBucketAttributes under the hood, only supplying the bucketArn attribute. You can see here how fromBucketAttributes calculates its other properties by default:

aws-cdk/packages/@aws-cdk/aws-s3/lib/bucket.ts

Lines 1612 to 1624 in 1485f48

	const newUrlFormat = attrs.bucketWebsiteNewUrlFormat === undefined
	? false
	: attrs.bucketWebsiteNewUrlFormat;
	const websiteDomain = newUrlFormat
	? `${bucketName}.s3-website.${region}.${urlSuffix}`
	: `${bucketName}.s3-website-${region}.${urlSuffix}`;
	class Import extends BucketBase {
	public readonly bucketName = bucketName!;
	public readonly bucketArn = parseBucketArn(scope, attrs);
	public readonly bucketDomainName = attrs.bucketDomainName || `${bucketName}.s3.${urlSuffix}`;
	public readonly bucketWebsiteUrl = attrs.bucketWebsiteUrl || `http://${websiteDomain}`;

websiteDomain will be set to ${bucketName}.s3-website-${region}.${urlSuffix} because newUrlFormat is disabled by default. Then bucketWebsiteUrl will be set to this websiteDomain: http://${websiteDomain}

We should be able to calculate this ourselves based on the region using the docs you linked. And if not, we should offer a way to override this setting. Thanks for reporting!

[mrgrain]

@peterwoodworth I don't think we can calculate this just from the ARN. Unfortunately Bucket ARNs do not contain a region. Wo do you think?
https://docs.aws.amazon.com/AmazonS3/latest/userguide/s3-arn-format.html

[mrgrain]

#23919 will fix this for scenarios where the destination bucket is in the same region as the stack.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.