fix(eks): nested OCI repository names for private ECR helmchart deployments are not properly handled

[psemeniuk]

Fixes #22340

I've changed the way of extracting components (registry domain & region) from repository to regexp with named capture groups.

I've tested it by extending integ.eks-helm-asset.ts with second deployment from manually created private ECR. But I didn't provide coverage for this issue, because before deployment private ECR has to be created and filled by an example chart - i'm not aware of any simple way to automate a second part in tests.

---

All Submissions:

• Have you followed the guidelines in our Contributing guide?

Adding new Construct Runtime Dependencies:

• This PR adds new construct runtime dependencies following the process described here

New Features

• Have you added the new feature to an integration test?
  • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[TheRealAmazonKendra]

I've tested it by extending integ.eks-helm-asset.ts with second deployment from manually created private ECR. But I didn't provide coverage for this issue, because before deployment private ECR has to be created and filled by an example chart - i'm not aware of any simple way to automate a second part in tests.

Add the steps for verification in a test file so that we have documentation in code of how this was tested. Please also add in the comments here the output of those tests. In the meantime, I'm going to re-open this and add exemptions so it doesn't get closed again.

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

[psemeniuk]

Manual testing steps added

Output:

$ integ-runner --update-on-failed integ.eks-helm-asset.js

Verifying integration test snapshots...

  CHANGED    integ.eks-helm-asset 5.066s
      Resources
[~] Custom::AWSCDK-EKS-HelmChart Clustercharttestocichart9C188967 
 └─ [~] Repository
     ├─ [-] oci://public.ecr.aws/aws-controllers-k8s/s3-chart
     └─ [+] oci://REDACTED.dkr.ecr.us-east-1.amazonaws.com/helm-charts-test/s3-chart



Snapshot Results: 

Tests:    1 failed, 1 total

Running integration tests for failed tests...

Running in parallel across regions: us-east-1, us-east-2, us-west-2
Running test /workspace/aws-cdk/packages/@aws-cdk/aws-eks/test/integ.eks-helm-asset.js in us-east-1
  SUCCESS    integ.eks-helm-asset-aws-cdk-eks-helm/DefaultTest 3179.091s
       NO ASSERTIONS

Test Results: 

Tests:    1 passed, 1 total
Done in 3185.22s.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[TheRealAmazonKendra]

@Mergifyio update

[mergify]

update

❌ Base branch update has failed

refusing to allow a GitHub App to create or update workflow .github/workflows/yarn-upgrade-v1main.yml without workflows permission
err-code: 0F0D0

Pull request has been modified.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: c00d80b
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).