feat(cli): --hotswap will not use CFN anymore, --hotswap-fallback to fall back if necessary

[comcalvi]

Changes the behavior of --hotswap to ignore all non-hotswappable changes and hotswap what it can. This works at two levels: changes to non-hotswappable resources are ignored, as well as non-hotswappable changes to hotswappable resources (eg Tags on a Lambda Function).

In addition, non-hotswappable changes are now logged; the logical ID, rejected changes, resource type, and reason why the changes were rejected are all provided for each non-hotswappable change.

At some point, support for hotswapping lambda function tags was added. This either broke or simply never worked, so this PR removes all logic for hotswapping tags.

The existing behavior of --hotswap can be used in --hotswap-fallback. It is preserved and unmodified by this change.

Closes #22784, #21773, #21556, #23640.

---

All Submissions:

• Have you followed the guidelines in our Contributing guide?

Adding new Construct Runtime Dependencies:

• This PR adds new construct runtime dependencies following the process described here

New Features

• Have you added the new feature to an integration test?
  • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mrgrain]

Maybe a name along this line is better?

Suggested change

	specify `--hotswap-fallback`, like so:
	specify `--hotswap-all`, like so:

[comcalvi]

it's a bit misleading, because it implies that all the resources will be hotswapped, when they'll be deployed via CFN. We could be really verbose and do --hotswap-fallback-to-cfn

[kevinjamescasey]

Maybe --hotswap-only could mean only update the hot-swappable things. Adding a new flag like that instead of changing the behavior of the existing flag could prevent breaking all the scripts that are already using that flag. It also allows the documentation to remain correct.

And --with-hotswap could be added as an alias for --hotswap if the original flag name is not clear enough.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 7449433
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).