Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iam): PrincipalWithConditions.addCondition fails with a new key #23782

Merged
merged 6 commits into from
Feb 12, 2023

Conversation

turenar
Copy link
Contributor

@turenar turenar commented Jan 22, 2023

fixes #23781

This pr makes PrincipalWithConditions.addCondition bypass validations on the existing condition object if missing.


All Submissions:

Adding new Construct Runtime Dependencies:

  • This PR adds new construct runtime dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 22, 2023

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 labels Jan 22, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team January 22, 2023 10:15
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@turenar turenar changed the title Add condition fails with new operator fix(iam): PrincipalWithConditions.addCondition fails with a new key Jan 22, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 22, 2023 10:25

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@turenar turenar marked this pull request as ready for review January 22, 2023 11:14
@turenar turenar force-pushed the add-condition-fails-with-new-operator branch from ccf55a5 to 71b7c5e Compare February 8, 2023 14:26
comcalvi
comcalvi previously approved these changes Feb 10, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 10, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@TheRealAmazonKendra
Copy link
Contributor

Mergify falling down on the job again.

@mergify mergify bot dismissed comcalvi’s stale review February 11, 2023 23:00

Pull request has been modified.

@TheRealAmazonKendra
Copy link
Contributor

error An unexpected error occurred: "https://registry.npmjs.org/markdown-it/-/markdown-it-12.3.2.tgz: Request failed \"502 Bad Gateway\"".

Node registry falling down on the job.

@mergify
Copy link
Contributor

mergify bot commented Feb 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9274548
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8951d01 into aws:main Feb 12, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iam: PrincipalWithConditions.addCondition fails with a new key (i.e. condition operator)
4 participants