Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(redshift): Tables can include comments #23847

Merged
merged 5 commits into from
Feb 3, 2023
Merged

feat(redshift): Tables can include comments #23847

merged 5 commits into from
Feb 3, 2023

Conversation

Rizxcviii
Copy link
Contributor

@Rizxcviii Rizxcviii commented Jan 26, 2023 •
edited
Loading

Adds comments to tables.

closes #22682

All Submissions:

Adding new Construct Runtime Dependencies:

  • This PR adds new construct runtime dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 26, 2023

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jan 26, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team January 26, 2023 10:56
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Jan 26, 2023
comcalvi
comcalvi previously requested changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 🙂 could we change the name from comment to tableComment, since SQL supports comments on columns as well?

packages/@aws-cdk/aws-redshift/lib/table.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-redshift/lib/private/handler-props.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-redshift/lib/private/database-query-provider/table.ts Outdated Show resolved Hide resolved
@comcalvi comcalvi self-assigned this Jan 30, 2023
@mergify mergify bot dismissed comcalvi’s stale review January 31, 2023 11:36

Pull request has been modified.

comcalvi
comcalvi previously approved these changes Jan 31, 2023
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Jan 31, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed comcalvi’s stale review January 31, 2023 23:27

Pull request has been modified.

comcalvi
comcalvi previously approved these changes Feb 2, 2023
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Feb 2, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@Rizxcviii
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2023

refresh

✅ Pull request refreshed

@Rizxcviii
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2023

refresh

✅ Pull request refreshed

@Rizxcviii
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2023

refresh

✅ Pull request refreshed

@Rizxcviii
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2023

refresh

✅ Pull request refreshed

@Rizxcviii
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2023

refresh

✅ Pull request refreshed

@Rizxcviii
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2023

refresh

✅ Pull request refreshed

@Rizxcviii
Copy link
Contributor Author

Rizxcviii commented Feb 3, 2023 •
edited
Loading

@comcalvi Within my fork, I've created a personal access token with read/write access to workflows, added it as a secret to the repository (same name that the .yml file asks for), and the merge still fails. The error message is below.

Base branch update has failed

refusing to allow a GitHub App to create or update workflow .github/workflows/close-stale-prs.yml without workflows permission
err-code: 9AD93

@mergify mergify bot dismissed comcalvi’s stale review February 3, 2023 11:34

Pull request has been modified.

@comcalvi
Copy link
Contributor

comcalvi commented Feb 3, 2023

very strange...not sure what's going on here

@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f30fb76
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 46cadd4 into aws:main Feb 3, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@Rizxcviii Rizxcviii deleted the feature/table-comments branch February 3, 2023 18:00
@Rizxcviii Rizxcviii mentioned this pull request Feb 6, 2023
Merged
4 tasks
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
This was referenced Sep 13, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comcalvi comcalvi comcalvi approved these changes

Assignees

@comcalvi comcalvi

Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@aws-cdk/aws-redshift-alpha: Add comments for redshift tables construct
3 participants
@Rizxcviii @comcalvi @aws-cdk-automation