feat(lambda): enable RuntimeManagementConfig #23891
Conversation
|
|
github-actions
bot
added
feature-request
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
| export interface RuntimeManagement { | ||
| /** | ||
| * The ARN of the runtime version you want the function to use. | ||
| * | ||
| * Note. | ||
| * This is only required if you're using the Manual runtime update mode. | ||
| * | ||
| * @default none | ||
| */ | ||
| readonly arn?: string; | ||
| /** | ||
| * Specify the runtime update mode. | ||
| */ | ||
| readonly mode: UpdateRuntimeOn; | ||
| } |
There was a problem hiding this comment.
Can we remove this interface, and just have runtimeManagementVersionArn and runtimeManagementMode as props?
There was a problem hiding this comment.
I changed this to flat.
| if (props.runtimeManagement) { | ||
| if (props.runtimeManagement.mode === UpdateRuntimeOn.MANUAL) { | ||
| rmc = { | ||
| runtimeVersionArn: props.runtimeManagement.arn, |
There was a problem hiding this comment.
we need to throw an error if runtimeManagement.arn is not defined
| * Sets the runtime management configuration for a function's version. | ||
| * @default Auto | ||
| */ | ||
| readonly runtimeManagement?: RuntimeManagement; |
There was a problem hiding this comment.
| readonly runtimeManagement?: RuntimeManagement; | |
| readonly runtimeManagementMode?: RuntimeManagementMode; | |
| readonly runtimeManagementVersionArn?: string; |
There was a problem hiding this comment.
Implemented as specified in .manual(arn) of RuntimeManagementMode.
Co-authored-by: Calvin Combs <[email protected]>
Co-authored-by: Calvin Combs <[email protected]>
Co-authored-by: Calvin Combs <[email protected]>
mergify
bot
dismissed
comcalvi’s stale review
Pull request has been modified.
|
Thank you. I have applied the patches I could, but I will try again. runtimeManagementMode: UpdateRuntimeOn.MANUAL_ARN(<someArn>) |
|
why |
|
That is a fair point. I was using the original parameter names as they are, but I will consider a proposal to revise the naming to match. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-lambda-function-runtimemanagementconfig.html#cfn- lambda-function-runtimemanagementconfig-updateruntimeon |
watany-dev
requested review from
comcalvi
and removed request for
aws-cdk-automation
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Introducing AWS Lambda runtime management controls
https://aws.amazon.com/jp/blogs/compute/introducing-aws-lambda-runtime-management-controls/
This setting achieves the following set values.
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-lambda-function.html#cfn-lambda-functionruntimemanagementconfig
I have not been able to test this CFn as it does not seem to be supported by cdk. It's only a design.
Closes #23890.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license