Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(efs): support file system policy #24196

Merged
merged 6 commits into from
Feb 16, 2023
Merged

feat(efs): support file system policy #24196

merged 6 commits into from
Feb 16, 2023

Conversation

zorrofox
Copy link
Contributor

@zorrofox zorrofox commented Feb 16, 2023 •
edited
Loading

Add support EFS File System Policy.

Closes #24042.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 16, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team February 16, 2023 05:18
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Feb 16, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review February 16, 2023 06:44

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@zorrofox zorrofox marked this pull request as ready for review February 16, 2023 06:52
TheRealAmazonKendra
TheRealAmazonKendra approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for your contribution!

@TheRealAmazonKendra TheRealAmazonKendra changed the title feat(efs): Add support EFS File System Policy feat(efs): add support for file system policy Feb 16, 2023
@TheRealAmazonKendra TheRealAmazonKendra changed the title feat(efs): add support for file system policy feat(efs): support file system policy Feb 16, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c49c8d0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5e0f44b into aws:main Feb 16, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
This was referenced Sep 13, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EFS: Support File System Policy
3 participants
@zorrofox @aws-cdk-automation @TheRealAmazonKendra