feat(eks): add helm flag --skip-crds #24213
Conversation
* Add the possibility to skip the installation of crds in a helm chart * Add tests for skipCrds property * Update README
|
|
github-actions
bot
added
the
beginning-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
alexandersperling
changed the title
|
Exemption Request Hi, I've updated the corresponding integ test file, but unfortunately I'm not able to run an integtest and update the snapshot. |
aws-cdk-automation
added
pr/reviewer-clarification-requested
|
Thank you for your contribution. I'll get these run today. |
github-actions
bot
added
the
feature-request
|
Apologies for the delay on this. I was helping troubleshoot another EKS issue that I suspected might impact this one. I didn't, but it took a while to get it resolved. Running those tests now! |
|
@Mergifyio update |
❌ Base branch update has failedrefusing to allow a GitHub App to create or update workflow |
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
TheRealAmazonKendra
removed
pr-linter/exemption-requested
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
When installing Helm chart sometimes it is needed to skip the installation of custom resource definitions. This MR adds the functionality to the helm chart construct. In fact I did the following * Add the possibility to skip the installation of crds in a helm chart via a new property * Add tests for skipCrds property * Update README Closes aws#24296 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
When installing Helm chart sometimes it is needed to skip the installation of custom resource definitions. This MR adds the functionality to the helm chart construct. In fact I did the following * Add the possibility to skip the installation of crds in a helm chart via a new property * Add tests for skipCrds property * Update README Closes aws#24296 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
When installing Helm chart sometimes it is needed to skip the installation of custom resource definitions. This MR adds the functionality to the helm chart construct. In fact I did the following * Add the possibility to skip the installation of crds in a helm chart via a new property * Add tests for skipCrds property * Update README Closes aws#24296 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
When installing Helm chart sometimes it is needed to skip the installation of custom resource definitions.
This MR adds the functionality to the helm chart construct.
In fact I did the following
Closes #24296
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license