fix(sns): sns subscription filter policy condition limit should be 150 #24269
Conversation
|
|
github-actions
bot
added
beginning-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Clarification Request: There are three integration tests in the |
aws-cdk-automation
added
the
pr/reviewer-clarification-requested
MrArnoldPalmer
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
There was a problem hiding this comment.
An integ test is not required here as the only logic changing is synth time so the unit test update covers it.
Additionally related to #23108, we can share complexity checking in a function in that PR to avoid repeating.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
eliasbrange
deleted the
fix/increase-sns-filter-policy-condition-limit-to-150
branch
#24269) The [Filter policy constraints docs](https://docs.aws.amazon.com/sns/latest/dg/subscription-filter-policy-constraints.html) says: > For the complexity of the filter policy, the total combination of values must not exceed 150. Calculate the total combination by multiplying the number of values in each array. This PR sets the complexity limit to the correct value. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
aws#24269) The [Filter policy constraints docs](https://docs.aws.amazon.com/sns/latest/dg/subscription-filter-policy-constraints.html) says: > For the complexity of the filter policy, the total combination of values must not exceed 150. Calculate the total combination by multiplying the number of values in each array. This PR sets the complexity limit to the correct value. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
aws#24269) The [Filter policy constraints docs](https://docs.aws.amazon.com/sns/latest/dg/subscription-filter-policy-constraints.html) says: > For the complexity of the filter policy, the total combination of values must not exceed 150. Calculate the total combination by multiplying the number of values in each array. This PR sets the complexity limit to the correct value. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
aws#24269) The [Filter policy constraints docs](https://docs.aws.amazon.com/sns/latest/dg/subscription-filter-policy-constraints.html) says: > For the complexity of the filter policy, the total combination of values must not exceed 150. Calculate the total combination by multiplying the number of values in each array. This PR sets the complexity limit to the correct value. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The Filter policy constraints docs says:
This PR sets the complexity limit to the correct value.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license