-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
servicecatalog: wrong asset path is generated in case outdir is an absolute path #24392
Closed
bruecktech opened this issue
Mar 1, 2023
· 2 comments
· Fixed by #24393 · May be fixed by WontonSam/apollo-federation-subgraph-compatibility#508, WontonSam/apollo-federation-subgraph-compatibility#511 or WontonSam/apollo-federation-subgraph-compatibility#523
Closed
servicecatalog: wrong asset path is generated in case outdir is an absolute path #24392
bruecktech opened this issue
Mar 1, 2023
· 2 comments
· Fixed by #24393 · May be fixed by WontonSam/apollo-federation-subgraph-compatibility#508, WontonSam/apollo-federation-subgraph-compatibility#511 or WontonSam/apollo-federation-subgraph-compatibility#523
Labels
@aws-cdk/aws-servicecatalog
Related to AWS Service Catalog
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
p2
Comments
bruecktech
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
Mar 1, 2023
github-actions
bot
added
the
@aws-cdk/aws-servicecatalog
Related to AWS Service Catalog
label
Mar 1, 2023
pahud
added
p2
effort/small
Small work item – less than a day of effort
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Mar 1, 2023
Yes this seems to be a bug when outdir is provided as an absolute path. Thank you for your PR. |
|
homakk
pushed a commit
to homakk/aws-cdk
that referenced
this issue
Mar 28, 2023
…absolute (aws#24393) In case we get an absolute path like `/tmp/foobar` then `./` is always prepended which makes the assetPath relative to the current directory. Fixes aws#24392 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-servicecatalog
Related to AWS Service Catalog
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
p2
Describe the bug
When synthesizing a service catalog product stack a wrong assetPath is generated in case outdir is an absolute path
Expected Behavior
stack should get synthesized with no error
Current Behavior
An exception is thrown
Reproduction Steps
write a test like this where NetworkStack contains a service catalog ProductStack that includes assets
Possible Solution
Remove
./
hereAdditional Information/Context
No response
CDK CLI Version
2.66.1
Framework Version
No response
Node.js Version
v16.16.0
OS
macOs Ventura
Language
Typescript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: