Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(s3-deployment): add yamlData #24554

Closed
1 of 2 tasks
RichiCoder1 opened this issue Mar 9, 2023 · 2 comments · Fixed by #24579
Closed
1 of 2 tasks

(s3-deployment): add yamlData #24554

RichiCoder1 opened this issue Mar 9, 2023 · 2 comments · Fixed by #24579
Labels
@aws-cdk/aws-s3-deployment effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@RichiCoder1
Copy link
Contributor

Describe the feature

The PR #18659 added the excellent data and jsonData helpers. I'd like to add a yamlData equivalent, which should just be the same as jsonData, but strigifyied to YAML.

Use Case

It's not uncommon for config files to be yaml instead of JSON (see Cloudformation :D), so I'd just like to be able to take advantage of the same optimization as jsonData

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

v2.68.0

Environment details (OS name and version, etc.)

Windows 11
@RichiCoder1 RichiCoder1 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 9, 2023
@khushail
Copy link
Contributor

khushail commented Mar 9, 2023

Hi @RichiCoder1 ,thanks for reaching out with this request.

I am marking this as P2 and we would be happy to review your PR when available. Sharing the contributing guide to get started.

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Mar 9, 2023
@lpizzinidev lpizzinidev mentioned this issue Mar 11, 2023
Merged
lpizzinidev added a commit to lpizzinidev/aws-cdk that referenced this issue Mar 28, 2023
@lpizzinidev
Merged main branch into awsgh-24554
cef656c
mergify bot added a commit to lpizzinidev/aws-cdk that referenced this issue Mar 29, 2023
@mergify
Merge branch 'main' into awsgh-24554
1ce72a0
@mergify mergify bot closed this as completed in #24579 Mar 29, 2023
mergify bot pushed a commit that referenced this issue Mar 29, 2023
@lpizzinidev
feat(s3-deployment): added Source.dataYaml helper function (#24579)
d969ddf 
Add the `Source.dataYaml` helper function to deploy an object with the specified object converted to YAML format.

Closes #24554.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-s3-deployment effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(s3-deployment): added Source.dataYaml helper function lpizzinidev/aws-cdk
2 participants
@RichiCoder1 @khushail