(app-mesh): Missing port property in GrpcRouteMatch construct

[neovasili]

Describe the bug

While the CfnRoute give us the ability to define a gRPC match route rule specifying the port, the L2 construct GrpcRouteMatch does not have that property (only have service_name, method_name and metadata), leveraging us to use L1 constructs instead if we want to use the port matcher.

Expected Behavior

GrpcRouteMatch L2 construct also let us specify the port matcher option.

Current Behavior

GrpcRouteMatch L2 construct does not have the property port.

Reproduction Steps

Example in python; the following is not valid code:

appmesh.RouteSpec.grpc(
    match=appmesh.GrpcRouteMatch(port=1234),
    weighted_targets=[appmesh.WeightedTarget(virtual_node=node)],
)

We need to use L1 construct, to get the same result:

appmesh.CfnRoute.RouteSpecProperty(
    grpc_route=appmesh.CfnRoute.GrpcRouteProperty(
        action=appmesh.CfnRoute.GrpcRouteActionProperty(
            weighted_targets=[appmesh.CfnRoute.WeightedTargetProperty(
                virtual_node=node.virtual_node_name,
                weight=1,
            )],
        ),
        match=appmesh.CfnRoute.GrpcRouteMatchProperty(port=1234),
    ),
)

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.81.0

Framework Version

2.81.0

Node.js Version

v16.14.2

OS

MacOs Ventura

Language

Python

Language Version

python 3.11.1

Other information

I have checked through the CDK docs that typescript CDK version have the same issue, so I guess this applies to all languages available.

[peterwoodworth]

Should be real simple to add, contributions are welcome

[neovasili]

Thanks @peterwoodworth, I will try to create a PR with the required changes.

[neovasili]

Created PR with the suggested change 😄

[peterwoodworth]

Thanks for the PR! We'll be able to give it a full review once its passing the build, but if you have any questions or need help getting to that state feel free to ping me and ask for help

[neovasili]

Thanks for the PR! We'll be able to give it a full review once its passing the build, but if you have any questions or need help getting to that state feel free to ping me and ask for help

I've updated the PR "fixing integration tests" and adding the port property to another construct I spotted during the process, but the build is still failing, although is kinda hard to find the issue, @peterwoodworth can you help me understand why is failing?

[neovasili]

Hi @peterwoodworth,

Build is passing now 😄 please let me know if anything else is required.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.