Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecs: wrong description for a property in ExecuteCommandLogConfiguration #25855

Closed
go-to-k opened this issue Jun 5, 2023 · 2 comments · Fixed by #25856
Closed

ecs: wrong description for a property in ExecuteCommandLogConfiguration #25855

go-to-k opened this issue Jun 5, 2023 · 2 comments · Fixed by #25856
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container documentation This is a problem with documentation. effort/medium Medium work item – several days of effort p2

Comments

@go-to-k
Copy link
Contributor

go-to-k commented Jun 5, 2023

Describe the issue

A description for the s3EncryptionEnabled in the ExecuteCommandLogConfiguration interface is wrong, which states
Whether or not to enable encryption on the CloudWatch logs.

The correct description would be S3 bucket, not CloudWatch logs.

Links

https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ecs.ExecuteCommandLogConfiguration.html
@go-to-k go-to-k added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Jun 5, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Jun 5, 2023
@go-to-k go-to-k mentioned this issue Jun 5, 2023
Merged
@pahud
Copy link
Contributor

pahud commented Jun 5, 2023

Thank you for your report and PR!

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jun 5, 2023
@mergify mergify bot closed this as completed in #25856 Jun 13, 2023
mergify bot pushed a commit that referenced this issue Jun 13, 2023
@go-to-k
docs(ecs): fix a property doc in ExecuteCommandLogConfiguration (#25856)
d90dffa 
As mentioned in #25855, a doc of the s3EncryptionEnabled in the ExecuteCommandLogConfiguration interface is wrong.

Closes #25855

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

This was referenced Jul 26, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container documentation This is a problem with documentation. effort/medium Medium work item – several days of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(ecs): fix a property doc in ExecuteCommandLogConfiguration go-to-k/aws-cdk
2 participants
@pahud @go-to-k