-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdk: cdk synth and cdk deploy create invalid property names s3StorageConfig and enableOnlineStore #25990
Comments
This See this comment for an example of how you should define something like this going forward #25774 (comment) |
|
Describe the bug
We are running
cdk synth
orcdk deploy
against a python stack that defines a SageMaker feature group.The properties validation as part of the
cdk deploy
command fails with the following error messages:#/OfflineStoreConfig: required key [S3StorageConfig] not found
#/OfflineStoreConfig: extraneous key [s3StorageConfig] is not permitted
#/OnlineStoreConfig: extraneous key [enableOnlineStore] is not permitted
The generated YAML Cloudformation representation looks as follows:
On the other hand the following documentation suggests that s3StorageConfig should start with a capital letter:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-sagemaker-featuregroup-offlinestoreconfig.html
Expected Behavior
The stack should be deployed with the correct spelling of the property names.
Current Behavior
The deployment of the stack fails due to the validation error with regards to the wrong property names.
Reproduction Steps
The following code produces the described issue in the YAML output, which can be displayed by running
cdk synth
Possible Solution
No response
Additional Information/Context
The YAML output (abbreviated) from the code snippet supplied.
The properties s3StorageConfig and s3Uri should actually start with captital s (S), we believe.
CDK CLI Version
2.84.0 (build f7c792f)
Framework Version
No response
Node.js Version
18
OS
Linux Debian (bookworm), macOS Big Sur (11.6)
Language
Python
Language Version
Python 3.9
Other information
We installed the following python packages
aws-cdk-lib==2.82.0
aws-cdk.asset-awscli-v1==2.2.186
aws-cdk.asset-kubectl-v20==2.1.1
aws-cdk.asset-node-proxy-agent-v5==2.0.155
constructs==10.2.45
The text was updated successfully, but these errors were encountered: