-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-cdk-lib/aws-elasticloadbalancingv2: custom health check timeouts sould be supported for Network Load Balancer health checks #26023
Labels
@aws-cdk/aws-elasticloadbalancingv2
Related to Amazon Elastic Load Balancing V2
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
p1
Comments
tmyoda
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
Jun 16, 2023
github-actions
bot
added
the
@aws-cdk/aws-elasticloadbalancingv2
Related to Amazon Elastic Load Balancing V2
label
Jun 16, 2023
tmyoda
changed the title
aws-cdk-lib/aws-elasticloadbalancingv2: Custom health check timeouts sould be supported for Network Load Balancer health checks
aws-cdk-lib/aws-elasticloadbalancingv2: custom health check timeouts sould be supported for Network Load Balancer health checks
Jun 16, 2023
I plan to work on a fix for this issue and will submit a pull request once it's ready. |
Thanks for reporting and for working on this @tmyoda! |
peterwoodworth
added
p1
effort/small
Small work item – less than a day of effort
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Jun 17, 2023
tmyoda
added a commit
to tmyoda/aws-cdk
that referenced
this issue
Jun 17, 2023
mergify bot
pushed a commit
that referenced
this issue
Jun 26, 2023
Following the update of Network Load Balancer (NLB) in November 2022, the range for setting HealthCheckTimeoutSeconds for NLB is now between 2 and 120 seconds. However, the CDK has yet to be updated to reflect this change. https://aws.amazon.com/about-aws/whats-new/2022/11/elastic-load-balancing-capabilities-application-availability/ https://docs.aws.amazon.com/elasticloadbalancing/latest/network/target-group-health-checks.html This PR addresses this by modifying the validation, enabling us to set the HealthCheckTimeoutSeconds for the NLB. I have modified and added the following validation in this PR: - Ensure that the HealthCheckTimeoutSeconds is between 2 and 120. - Ensure that HealthCheckTimeoutSeconds is not greater than HealthCheckIntervalSeconds. Closes #26023. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
lukey-aleios
pushed a commit
to lukey-aleios/aws-cdk
that referenced
this issue
Jun 30, 2023
Following the update of Network Load Balancer (NLB) in November 2022, the range for setting HealthCheckTimeoutSeconds for NLB is now between 2 and 120 seconds. However, the CDK has yet to be updated to reflect this change. https://aws.amazon.com/about-aws/whats-new/2022/11/elastic-load-balancing-capabilities-application-availability/ https://docs.aws.amazon.com/elasticloadbalancing/latest/network/target-group-health-checks.html This PR addresses this by modifying the validation, enabling us to set the HealthCheckTimeoutSeconds for the NLB. I have modified and added the following validation in this PR: - Ensure that the HealthCheckTimeoutSeconds is between 2 and 120. - Ensure that HealthCheckTimeoutSeconds is not greater than HealthCheckIntervalSeconds. Closes aws#26023. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
lukey-aleios
pushed a commit
to lukey-aleios/aws-cdk
that referenced
this issue
Jun 30, 2023
Following the update of Network Load Balancer (NLB) in November 2022, the range for setting HealthCheckTimeoutSeconds for NLB is now between 2 and 120 seconds. However, the CDK has yet to be updated to reflect this change. https://aws.amazon.com/about-aws/whats-new/2022/11/elastic-load-balancing-capabilities-application-availability/ https://docs.aws.amazon.com/elasticloadbalancing/latest/network/target-group-health-checks.html This PR addresses this by modifying the validation, enabling us to set the HealthCheckTimeoutSeconds for the NLB. I have modified and added the following validation in this PR: - Ensure that the HealthCheckTimeoutSeconds is between 2 and 120. - Ensure that HealthCheckTimeoutSeconds is not greater than HealthCheckIntervalSeconds. Closes aws#26023. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-elasticloadbalancingv2
Related to Amazon Elastic Load Balancing V2
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
p1
Describe the bug
After NLB updating November 2022, We can change HealthCheckTimeoutSeconds between 2–120 seconds
Elastic Load Balancing capabilities for application availability
https://aws.amazon.com/about-aws/whats-new/2022/11/elastic-load-balancing-capabilities-application-availability/
Health checks for your target groups - Elastic Load Balancing
https://docs.aws.amazon.com/elasticloadbalancing/latest/network/target-group-health-checks.html
However the latest CDK is still not updated yet.
https:/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/nlb/network-target-group.ts#L283-L288
Expected Behavior
The option HealthCheckTimeoutSeconds should be available.
Current Behavior
When I tried to deploy using custom health check timeout, It cause following error.
Reproduction Steps
Possible Solution
https:/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/nlb/network-target-group.ts#L283-L288
It seems that we need to modify the validation for the URL above.
Additional Information/Context
No response
CDK CLI Version
2.84.0 (build f7c792f)
Framework Version
No response
Node.js Version
v16.20.0
OS
Amazon Linux 2
Language
Typescript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: