-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(aws-secretsmanager): broken link to aws-rds #26037
Labels
@aws-cdk/aws-secretsmanager
Related to AWS Secrets Manager
documentation
This is a problem with documentation.
duplicate
This issue is a duplicate.
effort/small
Small work item – less than a day of effort
p2
Comments
azatoth
added
documentation
This is a problem with documentation.
needs-triage
This issue or PR still needs to be triaged.
labels
Jun 19, 2023
github-actions
bot
added
the
@aws-cdk/aws-secretsmanager
Related to AWS Secrets Manager
label
Jun 19, 2023
We should fix that in this README. Are you interested to submit a PR for that? |
pahud
added
p2
effort/small
Small work item – less than a day of effort
response-requested
Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
and removed
needs-triage
This issue or PR still needs to be triaged.
response-requested
Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
labels
Jun 19, 2023
Thanks for reporting, closing in favor of #24958 |
|
This was referenced Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-secretsmanager
Related to AWS Secrets Manager
documentation
This is a problem with documentation.
duplicate
This issue is a duplicate.
effort/small
Small work item – less than a day of effort
p2
Describe the issue
On the last line of the rotating database section, there's a link to
aws-rds
, but that link resolves to https:/aws/aws-cdk/blob/main/packages/%40aws-cdk/aws-rds/README.md, and not intra-document-wise to the RDS section at https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_rds-readme.html.Links
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_secretsmanager-readme.html#rotating-database-credentials
The text was updated successfully, but these errors were encountered: