Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_rds (Return all instance identifiers) #26249

Closed
1 of 2 tasks
amscheaws opened this issue Jul 5, 2023 · 2 comments
Closed
1 of 2 tasks

aws_rds (Return all instance identifiers) #26249

amscheaws opened this issue Jul 5, 2023 · 2 comments
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database duplicate This issue is a duplicate. feature-request A feature should be added or improved.

Comments

@amscheaws
Copy link

amscheaws commented Jul 5, 2023

Describe the feature

Be able to return all DB Instance Identifiers when the following property is called.

const cluster = new rds.DatabaseCluster(this, 'Database', { ... });
const identifiers = cluster.instanceIdentifiers;

It only returns the reader replicas' identifiers currently.

Use Case

The SSL/TSL rds-ca-2019 CA is expiring on Aug 22, 2024. I need to update the Instances' CA identifiers to rds-ca-rsa2048-g1.

I had a success using CfnDbInstance class along with the Instance Identifier to achieve this through following code.

var instanceId = 1;
foreach (string identifier in instanceIdentifiers)
{
    var id = $"db-instance-{instanceId}";
    var cfnDbInstance = new CfnDbInstance(this, id, new CfnDbInstanceProps
    {
        DbInstanceIdentifier = identifier,
        CaCertificationIdentifier = "rds-ca-rsa2048-g1",
    };
    instanceId++;
}

Proposed Solution

Create new property writerInstanceIdentifiers and readerInstanceIdentifiers and deprecating the existing one.

Other Information

Alternatively I tried using property instanceIdentifierBase to pre-define the instance identifier. But I didn't see the identifier value in CloudFormation after synth.

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.86.0

Environment details (OS name and version, etc.)

Windows Subsystem Linux (Ubuntu) 4.4.0-19041-Microsoft

@amscheaws amscheaws added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 5, 2023
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Jul 5, 2023
@amscheaws amscheaws changed the title (module name): (short issue description) aws_rds (Return all instance identifiers) Jul 5, 2023
@peterwoodworth peterwoodworth added duplicate This issue is a duplicate. and removed needs-triage This issue or PR still needs to be triaged. labels Jul 5, 2023
@peterwoodworth
Copy link
Contributor

This issue is already tracking this and there's a PR up for it (which may end up getting closed if we don't hear from the submitter soon). Feel free to give your opinion about creating separate properties in the linked issue or associated PR

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database duplicate This issue is a duplicate. feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

2 participants