Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-chatbot: make ISlackChannelConfiguration define addNotificationTopic(ITopic) #26391

Closed
2 tasks
mayconfrr opened this issue Jul 17, 2023 · 3 comments
Closed
2 tasks
Labels
@aws-cdk/aws-chatbot Related to AWS Chatbot duplicate This issue is a duplicate. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@mayconfrr
Copy link

Describe the feature

Right now you can only add topics if you create the chatbot slack configuration in the stack. You can't add topics to existing chatbot resources because SlackChannelConfiguration.fromSlackChannelConfigurationArn(...) returns an ISlackChannelConfiguration, which doesn't define the method to do so

Use Case

As a CDK developer
I want to add a notification topic to an existing chatbot slack resource through CDK
So that I don't have to manually add it using the AWS Console

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.87.0

Environment details (OS name and version, etc.)

Windows 10 Home Single Language, Version 22H2

@mayconfrr mayconfrr added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 17, 2023
@github-actions github-actions bot added the @aws-cdk/aws-chatbot Related to AWS Chatbot label Jul 17, 2023
@mayconfrr mayconfrr changed the title aws-cdk-lib/aws-chatbot: make ISlackChannelConfiguration define addNotificationTopic(ITopic) aws-chatbot: make ISlackChannelConfiguration define addNotificationTopic(ITopic) Jul 17, 2023
@khushail khushail assigned khushail and unassigned khushail Jul 17, 2023
@khushail khushail added effort/medium Medium work item – several days of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Jul 17, 2023
@khushail
Copy link
Contributor

Thanks @mayconfrr for submitting this feature request. I am marking this as P2 but you are welcome to submit a PR. Here is the contribution guide to get started.

@peterwoodworth peterwoodworth added the duplicate This issue is a duplicate. label Jul 17, 2023
@peterwoodworth
Copy link
Contributor

Closing as duplicate of #21171

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-chatbot Related to AWS Chatbot duplicate This issue is a duplicate. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

3 participants