-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_route53: Allow more fields from lower level construct (CfnRecordSet) into higher level Record constructs #26753
Closed
1 of 2 tasks
christow-aws opened this issue
Aug 14, 2023
· 2 comments
· Fixed by #28705 · May be fixed by stack-spot/app-handler-functions-template#2, stack-spot/eks-env-ts-template#2 or stack-spot/web-react-deploy#4
Closed
1 of 2 tasks
aws_route53: Allow more fields from lower level construct (CfnRecordSet) into higher level Record constructs #26753
christow-aws opened this issue
Aug 14, 2023
· 2 comments
· Fixed by #28705 · May be fixed by stack-spot/app-handler-functions-template#2, stack-spot/eks-env-ts-template#2 or stack-spot/web-react-deploy#4
Labels
@aws-cdk/aws-route53
Related to Amazon Route 53
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p2
Comments
christow-aws
added
feature-request
A feature should be added or improved.
needs-triage
This issue or PR still needs to be triaged.
labels
Aug 14, 2023
Yes I think we could at least expose the weight property in the RecordSetOptions. |
pahud
added
p2
effort/medium
Medium work item – several days of effort
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Aug 14, 2023
mergify bot
pushed a commit
that referenced
this issue
Jan 17, 2024
In this PR, I have implemented support for weighted routing. By passing the `weight` and `setIdentifier` parameters when registering a record, it is possible to perform weighted routing among records that share the same name and type. ```ts new route53.ARecord(this, `WeightedRecord${index}`, { zone: hostedZone, recordName: 'www', weight: 20, // added setIdentifier: 'uniqueId', // added target: route53.RecordTarget.fromIpAddresses('1.2.3.4'), }); ``` Closes #26753. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
This was referenced Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-route53
Related to Amazon Route 53
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p2
Describe the feature
When working with constructs such as
ARecord
, we cannot use a weighted routing policy directly from the construct props. Instead, we have to do something hacky like this:It'd be nice for there to be some sort of solution here that doesn't involve downcasting and knowledge of the guts of this construct to properly hack around.
Use Case
Weighted records of all types for route 53.
Proposed Solution
Not sure how useful this will be for someone who's actually going to do the work...
Since routing policies are mutually exclusive, perhaps some tagged union magic on a new "routing" field would help. For example:
(basically implement these routing policies from AWS' docs)
Other Information
No response
Acknowledgements
CDK version used
2, TypeScript
Environment details (OS name and version, etc.)
AL2 on x86
The text was updated successfully, but these errors were encountered: