Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(synthetics-alpha): add latest two NodeJS runtimes #26967

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

philipmw
Copy link
Contributor

@philipmw philipmw commented Sep 1, 2023

This adds the ability to use the latest two NodeJS runtimes in your Synthetics construct.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This adds the ability to use the latest two NodeJS runtimes in
your Synthetics construct.
@github-actions github-actions bot added the p2 label Sep 1, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 1, 2023 05:10
@github-actions github-actions bot added the repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK label Sep 1, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 1, 2023
@mrgrain mrgrain changed the title chore(synthetics-alpha): add latest two NodeJS runtimes feat(synthetics-alpha): add latest two NodeJS runtimes Sep 1, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mrgrain mrgrain added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Sep 1, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 1, 2023
@mrgrain mrgrain added the pr-linter/exempt-readme The PR linter will not require README changes label Sep 1, 2023
@mrgrain
Copy link
Contributor

mrgrain commented Sep 1, 2023

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@aws-cdk-automation aws-cdk-automation dismissed their stale review September 1, 2023 10:05

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b7d73aa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0a0b37c into aws:main Sep 1, 2023
8 checks passed
@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mikewrighton pushed a commit that referenced this pull request Sep 14, 2023
This adds the ability to use the latest two NodeJS runtimes in your Synthetics construct.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@philipmw philipmw deleted the synthetics-runtimes branch October 4, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants