Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS CDK RDS: Examples containing deprecated InstanceProps #27495

Closed
pergardebrink opened this issue Oct 11, 2023 · 3 comments · Fixed by #27499
Closed

AWS CDK RDS: Examples containing deprecated InstanceProps #27495

pergardebrink opened this issue Oct 11, 2023 · 3 comments · Fixed by #27499
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database documentation This is a problem with documentation. effort/small Small work item – less than a day of effort p2

Comments

@pergardebrink
Copy link

Describe the issue

The documentation for a few RDS module examples are using the deprecated InstanceProps. Copying the sample would not use the new writer/reader api:

For example, copying the sample from here: https://docs.aws.amazon.com/cdk/api/v2/dotnet/api/Amazon.CDK.AWS.RDS.AuroraPostgresEngineVersion.html

Will look like this:
image

Links

Example:
https://docs.aws.amazon.com/cdk/api/v2/dotnet/api/Amazon.CDK.AWS.RDS.AuroraPostgresEngineVersion.html
@pergardebrink pergardebrink added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Oct 11, 2023
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Oct 11, 2023
@msambol
Copy link
Contributor

msambol commented Oct 11, 2023

@peterwoodworth I'll take this.

@msambol msambol mentioned this issue Oct 11, 2023
Merged
@peterwoodworth
Copy link
Contributor

thanks!

@peterwoodworth peterwoodworth added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Oct 11, 2023
@mergify mergify bot closed this as completed in #27499 Oct 12, 2023
mergify bot pushed a commit that referenced this issue Oct 12, 2023
@msambol
docs(rds): update deprecated InstanceProps example (#27499)
b2200a8 
Updating example that uses deprecated `InstanceProps`.
Also updating MySQL version for others as I got this error: `Cannot find version 5.7.mysql_aurora.2.08.1 for aurora-mysql`.

Closes #27495.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database documentation This is a problem with documentation. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(rds): update deprecated InstanceProps example msambol/aws-cdk
3 participants
@msambol @pergardebrink @peterwoodworth