Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-ecs-patterns): Configurable stopTimeout for Queue Processing Services #27519

Open
1 of 2 tasks
gilday opened this issue Oct 12, 2023 · 1 comment
Open
1 of 2 tasks
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@gilday
Copy link

gilday commented Oct 12, 2023

Describe the feature

The constructs QueueProcessingFargateServiceProps and QueueProcessingEc2ServiceProps provide no way to configure the stopTimeout parameter for the container definitions that these constructs create.

Use Case

The stopTimeout parameters is particularly important for queue processing services to ensure that the process has time to drain its in-progress tasks before stopping.

Proposed Solution

QueueProcessingServiceBaseProps includes parameters used by each of these constructs to create a ContainerDefinition, and it would be an obvious place to add a stopTimeout parameter, so that users may configure this value.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.87.0

Environment details (OS name and version, etc.)

macOS 14.0, Node v20.8.0, openjdk version "17.0.8.1" 2023-08-24

@gilday gilday added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 12, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ecs-patterns Related to ecs-patterns library label Oct 12, 2023
@peterwoodworth peterwoodworth added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Oct 12, 2023
@peterwoodworth
Copy link
Contributor

Hey, there are a number of similar reported FRs for our patterns constructs. Our patterns are opinionated, if you need fine control over the resources we suggest dropping down to the L2 constructs.

That said, we can still accept this as a feature request, thanks for the ask

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

2 participants