(elbv2): Circular dependency when enabling logaccesslogs on bucket in extended ALB construct

[peterwoodworth]

Describe the bug

The comment here describes the issue perfectly

Expected Behavior

I expect there to be no circular dependency

Current Behavior

There is a circular dependency

Reproduction Steps

export class CustomLB extends ApplicationLoadBalancer {

  constructor(scope: Construct, id: string, vpc: cdk.aws_ec2.IVpc) {
    super(scope, id, { vpc });

    const accessLogsBucket = new Bucket(this, `ALBAccessLogsBucket`, {      
      blockPublicAccess: BlockPublicAccess.BLOCK_ALL,
      encryption: BucketEncryption.S3_MANAGED,
      versioned: true,
      serverAccessLogsPrefix: 'selflog/',
      enforceSSL: true,
    });

    this.logAccessLogs(accessLogsBucket);
  }
}

Possible Solution

Only add a dependency on the CfnLoadBalancer, instead of the L2 construct

aws-cdk/packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/shared/base-load-balancer.ts

Lines 285 to 286 in b2200a8

	// make sure the bucket's policy is created before the ALB (see https:/aws/aws-cdk/issues/1633)
	this.node.addDependency(bucket);

Additional Information/Context

No response

CDK CLI Version

latest

Framework Version

No response

Node.js Version

18

OS

mac

Language

TypeScript

Language Version

No response

Other information

I'm not sure if this will have unintentional consequences with the proposed fix

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.