-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-signer: Signer Profile construct should support Notation-OCI-SHA384-ECDSA platform #28580
Closed
1 of 2 tasks
Sohail-Haaris-bah opened this issue
Jan 4, 2024
· 2 comments
· Fixed by #28612 · May be fixed by stack-spot/app-handler-functions-template#2, stack-spot/eks-env-ts-template#2 or stack-spot/web-react-deploy#4
Closed
1 of 2 tasks
aws-signer: Signer Profile construct should support Notation-OCI-SHA384-ECDSA platform #28580
Sohail-Haaris-bah opened this issue
Jan 4, 2024
· 2 comments
· Fixed by #28612 · May be fixed by stack-spot/app-handler-functions-template#2, stack-spot/eks-env-ts-template#2 or stack-spot/web-react-deploy#4
Labels
@aws-cdk/aws-signer
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
p2
Comments
Sohail-Haaris-bah
added
feature-request
A feature should be added or improved.
needs-triage
This issue or PR still needs to be triaged.
labels
Jan 4, 2024
Awesome! Thanks for the PR! |
pahud
added
p2
effort/small
Small work item – less than a day of effort
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Jan 4, 2024
mergify bot
pushed a commit
that referenced
this issue
Jan 8, 2024
Adds support for the `Notation-OCI-SHA384-ECDSA` signing profile platform. Also, refactors the `Platform` class to an enum-like class to allow custom platforms (and prevent blocking users if added platforms are missing on the `enum` declaration). Closes #28580. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
This was referenced Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-signer
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
p2
Describe the feature
The L2 construct for creating a Signer Profile in AWS Signer doesn't support creating a singer profile with the
Notation-OCI-SHA384-ECDSA
signing platform. This is odd, given that the L1 construct for it does. As such, I'd like to open a PR for the construct to add this capability, assuming that it just involves adding an instantiation to thePlatform
class.Use Case
AWS documentation recommends using this particular signing profile for creating an AWS Signer configuration for signing Docker images that get pushed to an ECR repository.
Proposed Solution
Adding a new enum value for the Platform class. https:/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-signer/lib/signing-profile.ts#L9
Other Information
No response
Acknowledgements
CDK version used
2.x
Environment details (OS name and version, etc.)
MacOS
The text was updated successfully, but these errors were encountered: