-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(sns): remove an unused variable declaration in Archive Policy #29590
Labels
@aws-cdk/aws-sns
Related to Amazon Simple Notification Service
bug
This issue is a bug.
documentation
This is a problem with documentation.
effort/small
Small work item – less than a day of effort
p2
Comments
jun1-t
added
documentation
This is a problem with documentation.
needs-triage
This issue or PR still needs to be triaged.
labels
Mar 23, 2024
github-actions
bot
added
the
@aws-cdk/aws-sns
Related to Amazon Simple Notification Service
label
Mar 23, 2024
jun1-t
changed the title
docs(sns): Typo in Archive Policy
docs(sns): remove an unused variable declaration in Archive Policy
Mar 23, 2024
Thanks for reporting this issue and creating the PR! |
tim-finnigan
added
bug
This issue is a bug.
p2
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Mar 25, 2024
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
@aws-cdk/aws-sns
Related to Amazon Simple Notification Service
bug
This issue is a bug.
documentation
This is a problem with documentation.
effort/small
Small work item – less than a day of effort
p2
Describe the issue
Archive Policy parameter in the aws_cdk_sns document has an unused variable declaration.
Currently the documentation says:
Example with an archive policy for SQS:
I think the following is better.
Example with an archive policy:
Removed "for SQS" and "declare const role: iam.Role;".
Links
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_sns-readme.html#archive-policy
The text was updated successfully, but these errors were encountered: