custom_resources: Broken source code links in "Provider Framework Examples" section

[glacius-mitchell]

Describe the issue

The source code links in the Provider Framework Examples section are broken:

S3File
Provisions an object in an S3 bucket with textual contents. See the source code for the construct and handler.

S3Assert
Checks that the textual contents of an S3 object matches a certain value. The check will be retried for 5 minutes as long as the object is not found or the value is different. See the source code for the construct and handler.

In particular, they all point to files under https:/aws/aws-cdk/tree/main/packages/aws-cdk-lib/custom-resources/test/provider-framework/integration-test-fixtures/, which no longer exists.

That directory has been relocated to https:/aws/aws-cdk/tree/main/packages/%40aws-cdk-testing/framework-integ/test/custom-resources/test/provider-framework/integration-test-fixtures and the links should be updated accordingly.

Current broken links:

• https:/aws/aws-cdk/blob/main/packages/aws-cdk-lib/custom-resources/test/provider-framework/integration-test-fixtures/s3-file.ts
• https:/aws/aws-cdk/blob/main/packages/aws-cdk-lib/custom-resources/test/provider-framework/integration-test-fixtures/s3-file-handler/index.ts
• https:/aws/aws-cdk/blob/main/packages/aws-cdk-lib/custom-resources/test/provider-framework/integration-test-fixtures/s3-assert.ts
• https:/aws/aws-cdk/blob/main/packages/aws-cdk-lib/custom-resources/test/provider-framework/integration-test-fixtures/s3-assert-handler/index.py

Proposed working links:

• https:/aws/aws-cdk/blob/main/packages/%40aws-cdk-testing/framework-integ/test/custom-resources/test/provider-framework/integration-test-fixtures/s3-file.ts
• https:/aws/aws-cdk/blob/main/packages/%40aws-cdk-testing/framework-integ/test/custom-resources/test/provider-framework/integration-test-fixtures/s3-file-handler/index.ts
• https:/aws/aws-cdk/blob/main/packages/%40aws-cdk-testing/framework-integ/test/custom-resources/test/provider-framework/integration-test-fixtures/s3-assert.ts
• https:/aws/aws-cdk/blob/main/packages/%40aws-cdk-testing/framework-integ/test/custom-resources/test/provider-framework/integration-test-fixtures/s3-assert-handler/index.py

Links

• https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.custom_resources-readme.html#provider-framework-examples
• https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.custom_resources-readme.html#s3file
• https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.custom_resources-readme.html#s3assert

[khushail]

Hi @glacius-mitchell , thanks for reaching out.

The mentioned broken links have been fixed in this PR, merged 5 days ago. It should be working soon in the next release.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[glacius-mitchell]

Hi @glacius-mitchell , thanks for reaching out.

The mentioned broken links have been fixed in this PR, merged 5 days ago. It should be working soon in the next release.

Perfect, thanks!

[aws-cdk-automation]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.