-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonfunction: BundlingOptions/Bundling Props interface mismatch #29697
Comments
I'm not too sure what the source of the issue is here. The parameters you've mentioned such as If you could provide a full snippet showing where you're running into problems, I can help resolve things better. |
This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled. |
I'll work on trying to replicate this issue this week. |
Ok, this looks like it might be a bug on our side, so I'm gonna close for now. |
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Describe the bug
In the PythonFunction construct,
bundling
expectsBundlingOptions
. However, the actualbundle
method expectsBundleProps
.Expected Behavior
I think the expected behavior of this code, is that the spread operator will allow you specify whatever additional options you want.
Current Behavior
Given the type mismatch, I believe it then resolves any missing props from BundlingProps to
never
. For example, this means that if you give any value forbundling
, that it's impossible to specifyArchitecture
, as that doesn't exist onBundlingOptions
.Reproduction Steps
Set a new image for a PythonFunction in
bundling
, setArchitecture
toArchitecture.ARM64
. Set theplatform
value tolinux/arm64
. Docker still attempts to build with x86.Possible Solution
The expected type for
bundling
should beBundlingProps
, notBundlingOptions
.Additional Information/Context
No response
CDK CLI Version
2.135.0
Framework Version
No response
Node.js Version
20
OS
macOS Sonoma
Language
Python
Language Version
3.12
Other information
No response
The text was updated successfully, but these errors were encountered: