-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(crossRegionReference): error logging for throwIfAnyInUse fails to log exports in use #29699
Closed
elliotsegler opened this issue
Apr 3, 2024
· 3 comments
· Fixed by #29961, rwlxxvii/containers#124 or rwlxxvii/containers#140 · May be fixed by NOUIY/aws-solutions-constructs#99 or NOUIY/aws-solutions-constructs#101
Closed
(crossRegionReference): error logging for throwIfAnyInUse fails to log exports in use #29699
elliotsegler opened this issue
Apr 3, 2024
· 3 comments
· Fixed by #29961, rwlxxvii/containers#124 or rwlxxvii/containers#140 · May be fixed by NOUIY/aws-solutions-constructs#99 or NOUIY/aws-solutions-constructs#101
Labels
bug
This issue is a bug.
investigating
This issue is being investigated and/or work is in progress to resolve the issue.
package/tools
Related to AWS CDK Tools or CLI
Comments
elliotsegler
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
Apr 3, 2024
khushail
added
investigating
This issue is being investigated and/or work is in progress to resolve the issue.
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Apr 5, 2024
andreialecu
added a commit
to andreialecu/aws-cdk
that referenced
this issue
Apr 25, 2024
1 task
PR at #29961 with fix. |
mergify bot
pushed a commit
that referenced
this issue
Apr 26, 2024
…29961) ### Issue #29699 Closes #29699 ### Reason for this change The logic was incorrectly using `Object.entries()` on a Map. ### Description of changes This is a straighforward change to properly handle the map, and an update to tests. ### Description of how you validated changes Updated test ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https:/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https:/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
This was referenced Jun 22, 2024
This was referenced Jul 5, 2024
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bug
This issue is a bug.
investigating
This issue is being investigated and/or work is in progress to resolve the issue.
package/tools
Related to AWS CDK Tools or CLI
Describe the bug
Discovered whilst debugging an issue with cross-stack exports, it looks like the error message logic that would identify which exports are in use by which stack is broken.
aws-cdk/packages/@aws-cdk/custom-resource-handlers/lib/core/cross-region-ssm-writer-handler/index.ts
Lines 104 to 109 in 36fd79d
In my case, there are
tagResults
but the results aren't mapped into the error message, so you just get a clear line in the error message.Expected Behavior
The error message to identify which exports are in use by which stacks.
For example:
Current Behavior
Error message doesn't include the content
Example
this appears to be the case in a number of issues:
#27251
#28200
#24464
#27902
Reproduction Steps
Create a cross region stack that uses an export, and then try to destroy the exporting stack first
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.118.0 (build a40f2ec)
Framework Version
No response
Node.js Version
v18.9.0
OS
arn:aws:lambda:us-east-1::runtime:464db84005d4f68e67934a6df703e04e6e8782a50ec2882673a8e1c996ab814a
Language
TypeScript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: