Required physical names should be "string" and not "PhysicalName" #2971
Comments
eladb
pushed a commit
that referenced
this issue
Jun 20, 2019
Additional minor API cleanups in the core module (see breaking changes list). Updated physical names linter rule to verify that physical name property name is `cfnTypeName` and that it's type is either `PhysicalName` in case the name is optional and `string` if the name is required (fixes #2971). Moved all internal files in @aws-cdk/cdk under "private" BREAKING CHANGE: The deprecated `app.run()` has been removed (use `app.synth()`). * **core:** `CfnElement.refAsString` renamed to `ref` of `string` type. The `IResolvable` version have been removed. * **core:** `Resource.physicalName` is now a `string` instead of `PhysicalName`. If a physical name should be generated during deployment (i.e. not supplied to L1), the string will synthesize to `undefined`. * **core:** `IStringValue` renamed to `IStringProducer` * **core:** `Include` renamed to `CfnInclude` * **core:** `Cfn` prefix was added to the following types: `CfnCreationPolicy`, `CfnResourceAutoScalingCreationPolicy`, `CfnResourceAutoScalingCreationPolicy`, `CfnDeletionPolicy`, `CfnUpdatePolicy`, `CfnAutoScalingRollingUpdate`, `CfnAutoScalingReplacingUpdate`, `CfnAutoScalingScheduledAction`, `CfnCodeDeployLambdaAliasUpdate`, `CfnTag` `CfnRuleAssertion`, `CfnDynamicReferenceProps` * **core:** `deepMerge` is no longer exported. * **core:** `CfnOutputProps.export` was renamed to `exportName`. * **core:** `CfnOutput` all properties are now private * **core:** `StringListCfnOutput` has been removed
4 tasks
eladb
pushed a commit
that referenced
this issue
Jun 21, 2019
Additional minor API cleanups in the core module (see breaking changes list). Updated physical names linter rule to verify that physical name property name is `cfnTypeName` and that it's type is either `PhysicalName` in case the name is optional and `string` if the name is required (fixes #2971). Moved all internal files in @aws-cdk/cdk under "private" BREAKING CHANGE: The deprecated `app.run()` has been removed (use `app.synth()`). * **core:** `CfnElement.refAsString` renamed to `ref` of `string` type. The `IResolvable` version have been removed. * **core:** `Resource.physicalName` is now a `string` instead of `PhysicalName`. If a physical name should be generated during deployment (i.e. not supplied to L1), the string will synthesize to `undefined`. * **core:** `IStringValue` renamed to `IStringProducer` * **core:** `Include` renamed to `CfnInclude` * **core:** `Cfn` prefix was added to the following types: `CfnCreationPolicy`, `CfnResourceAutoScalingCreationPolicy`, `CfnResourceAutoScalingCreationPolicy`, `CfnDeletionPolicy`, `CfnUpdatePolicy`, `CfnAutoScalingRollingUpdate`, `CfnAutoScalingReplacingUpdate`, `CfnAutoScalingScheduledAction`, `CfnCodeDeployLambdaAliasUpdate`, `CfnTag` `CfnRuleAssertion`, `CfnDynamicReferenceProps` * **core:** `deepMerge` is no longer exported. * **core:** `CfnOutputProps.export` was renamed to `exportName`. * **core:** `CfnOutput` all properties are now private * **core:** `StringListCfnOutput` has been removed
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
This was referenced Sep 24, 2024
Open
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If an L2 physical name is required, it's type should actually be a
stringinstead ofPhysicalNamesince users would have to specify it.The text was updated successfully, but these errors were encountered: