-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deploy: byte-order-mark (BOM) in existing cf template causes YAMLSyntaxError and fails deployment #29792
Comments
This seems to be an edge case. Can you explain why you need to do this? |
Obviously the BOM isn't being added intentionally - but editors will do this to files. If this is valid CF then cdk should work with it - if it is not valid CF then the console should reject it. At minimum cdk should produce accurate error messages. This won't catch me out again, but others might not be so lucky to spot the issue. |
Describe the bug
When performing manual tweaks to stacks in the console (eg - migrating resources into nested) users can provide a template that starts with a byte-order-mark and this is accepted by the console.
On subsequent deployments using CDK this causes a deployment failure. Updating the stack in console to remove the BOM fixes the issue.
Expected Behavior
aws-cdk should not have different behaviour to the console upload
Current Behavior
Reproduction Steps
Possible Solution
No response
Additional Information/Context
Important to note that all manual work was done in json, so I assume the yaml error was part of an internal process.
CDK CLI Version
2.136.0 (build 94fd33b)
Framework Version
No response
Node.js Version
v18.20.1
OS
Debian 12
Language
.NET
Language Version
8.0.203
Other information
No response
The text was updated successfully, but these errors were encountered: