Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticloadbalancingv2: fail to deploy integ test for NLB attributes #29970

Closed
badmintoncryer opened this issue Apr 26, 2024 · 2 comments
Closed
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@badmintoncryer
Copy link
Contributor

badmintoncryer commented Apr 26, 2024

Describe the bug

Integ test for NLB attributes (integ.nlb-attributes.ts) fails to deploy due to an error.

new elbv2.NetworkLoadBalancer(stack, 'NLB', {
  vpc,
  crossZoneEnabled: true,
  deletionProtection: false,
  denyAllIgwTraffic: true, // This parameter is not configurable for IPV4 loadbalancer
  clientRoutingPolicy: elbv2.ClientRoutingPolicy.PARTIAL_AVAILABILITY_ZONE_AFFINITY,
});

The snapshot derived from this test is incorrect, and errors are occurring when making the related corrections.

Expected Behavior

Fix the integration test to ensure it deploys successfully.

  • Remove the denyAllIgwTraffic setting from integ.nlb-attribute.ts
  • Instead, set denyAllIgwTraffic in integ.nlb.dualstack.internal.ts.

Current Behavior

integ.nlb-attributes.ts integ test fails to deploy

Load balancer attribute key 'ipv6.deny_all_igw_traffic' is not supported on load balancers with IP address type 'ipv4'

Reproduction Steps

Specify denyAllIgwTraffic for IPV4 IP address type loadbalancer.

new elbv2.NetworkLoadBalancer(stack, 'NLB', {
  vpc,
  ipAddressType: elbv2.IpAddressType.IPV4,
  denyAllIgwTraffic: true, // This parameter is not configurable for IPV4 loadbalancer
});

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.138.0

Framework Version

No response

Node.js Version

v20.10.0

OS

irreable

Language

TypeScript

Language Version

No response

Other information

No response

@badmintoncryer badmintoncryer added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 26, 2024
@github-actions github-actions bot added the @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 label Apr 26, 2024
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants