Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom-resource: support isComplete handler for AwsCustomResource #31062

Open
2 tasks
maltejk opened this issue Aug 8, 2024 · 2 comments
Open
2 tasks

custom-resource: support isComplete handler for AwsCustomResource #31062

maltejk opened this issue Aug 8, 2024 · 2 comments
Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@maltejk
Copy link

maltejk commented Aug 8, 2024

Describe the feature

Please add the isCompleteHandler functionality to AwsCustomResource also.

Thank you for your consideration!

As suggested by @hoegertn

Use Case

When I make use of AwsCustomResource to ModifyVpnTunnelOptions, I would not know when the modification completed. As I need to modify both tunnels, adding a dependency would not help. The second AwsCustomResource to run ModifyVpnTunnelOptions would start and fail with an error as the VPN is in state "modifying".

So I would end up creating a CustomResource, so I can make use of the isCompleteHandler.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.150.0

Environment details (OS name and version, etc.)

Darwin mbp.local 23.5.0 Darwin Kernel Version 23.5.0: Wed May 1 20:19:05 PDT 2024; root:xnu-10063.121.3~5/RELEASE_ARM64_T8112 arm64

@maltejk maltejk added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 8, 2024
@github-actions github-actions bot added the @aws-cdk/custom-resources Related to AWS CDK Custom Resources label Aug 8, 2024
@pahud
Copy link
Contributor

pahud commented Aug 8, 2024

Generally we'll recommend CustomResource in tis case but we welcome any feature requests. Please help us prioritize by 👍

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Aug 8, 2024
@hoegertn
Copy link
Contributor

hoegertn commented Aug 8, 2024

Having the isComplete handler as part of the AwsCustomResource would help a lot with undifferentiated heavy-lifting as several APIs return without the modification being ready. A polling mech to wait for this to happen would help with all AwsCustomResources that are not read-only.

I will look into drafting a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

3 participants