fix(rds): proxy target group does not depend on database instances when using writer property for database cluster #31354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #31304 .
Reason for this change
Proxy Target Group should depend on and wait for Aurora instances to be ready before creating CloudFormation resource. (see the issue).
Now, the dependency is added when using a legacy
instanceProps
, but not added when using awriter
property.https:/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-rds/lib/proxy.ts#L535-L539
(The cluster has
CfnDBInstance
directly when using theinstanceProps
, but it hasAuroraClusterInstance
withCfnDBInstance
asdefaultChild
when using thewriter
. So the cluster doesn't have theCfnDBInstance
directly in the latter case.)Description of changes
Added the dependency when using a
writer
property instead ofinstanceProps
.Description of how you validated changes
Both unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license