Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC2: SupportedIpAddressType support for VpcEndpointService #31797

Open
1 of 2 tasks
jsicheng opened this issue Oct 17, 2024 · 1 comment
Open
1 of 2 tasks

EC2: SupportedIpAddressType support for VpcEndpointService #31797

jsicheng opened this issue Oct 17, 2024 · 1 comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p2

Comments

@jsicheng
Copy link

Describe the feature

The CreateVpcEndpointServiceConfiguration EC2 API supports the SupportedIpAddressType parameter. We would like the same parameter to be configurable through the VpcEndpointService CDK construct.

Use Case

We are creating a VPC Endpoint Service for our DualStack Network Load Balancer. When creating the VpcEndpointService, the supported IP address types is only IPv4.

Proposed Solution

Support the supportedIpAddressType parameter for the VpcEndpointService construct:

new VpcEndpointService(this, 'TestVpcEndpointService', {
    vpcEndpointServiceLoadBalancers: [testLoadBalancer1, testLoadBalancer2],
    allowedPrincipals: [new ArnPrincipal('arn:aws:iam::xxxxxxxxxxxx:role/TestRole')],
    acceptanceRequired: true,
    contributorInsights: true,
    supportedIpAddressType, IpAddressType.DUAL_STACK,
});

Other Information

Our current workaround is to make a ModifyVpcEndpointServiceConfiguration call to add IPv6 support, but would like for the VpcEndpointService construct to support this during creation.

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.135.0

Environment details (OS name and version, etc.)

AL2

@jsicheng jsicheng added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 17, 2024
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Oct 17, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Oct 17, 2024
@khushail
Copy link
Contributor

Hi @jsicheng , thanks for reaching out.
For this property to be supported by CDK, it has to be first available by Cloudformation as its missing the cloudformation support right now -https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-vpcendpointservice.html#cfn-ec2-vpcendpointservice-networkloadbalancerarns

For that purpose, you could start with creating an an enhancement feature request with Cloudformation team on their coverage roadmap.
Once its provided in cloudformation, it could be further made available via L2 construct.

let me know if you need any more help or guidance on the same.
Thanks.

@khushail khushail added needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p2 effort/medium Medium work item – several days of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p2
Projects
None yet
Development

No branches or pull requests

2 participants