Unable to use CfnParameter valueAsNumber in SQS Queue

[amwill04]

If trying to use a CfnParameter with a SQS Queue you end up with the following error:

message retention period must be 60 seconds or more, but -1.8881545897087585e+289 was provided

Reproduction Steps

        const redemptionPeriod = new CfnParameter(this, 'RedendtionPeriod', {
            description: 'SQS redention period in seconds 60 - 1209600 [14400]',
            type: 'Number',
            default: 14400,
            minValue: 60,
            maxValue: 1209600,
            constraintDescription: 'Must be between 60 and 1209600',
        });

        return new Queue(this, 'Queue', {
            queueName: 'queue',
            retentionPeriod: Duration.seconds(redemptionPeriod.valueAsNumber), // This pass typechecking but will at best fail and at worst pass with the incorrect number.
            deliveryDelay: Duration.seconds(0),
            maxMessageSizeBytes: 1024,
            receiveMessageWaitTime: Duration.seconds(20),
            visibilityTimeout: Duration.seconds(60),
        });

Error Log

message retention period must be 60 seconds or more, but -1.8881545897087585e+289 was provided

Environment

• **CLI Version :1.31.0
• **Framework Version:1.31.0
• **OS :MacOS
• **Language :Typescript

This is 🐛 Bug Report

[MrArnoldPalmer]

@shivlaks what is the right way to do this?

[eladb]

Interesting! I think Durarion.seconds should be token-aware and just pass through the token to toSeconds and fail in all other conversions.

[amwill04]

@eladb it only seems to fail only with SQS. It seems to work fine with other resources such as Lambda.

[shivlaks]

@amwill04 I think it works for Lambda because of an oversight where the retry parameter doesn't seem to have any validation for it.

i.e. the range for retry should be between 3 and 900 seconds, but the following will build and synth successfully (although it will fail during deployment because it's an invalid timeout value)

const handler = new lambda.Function(stack, 'handler', {
      handler: 'index.handler',
      code: lambda.Code.fromInline('boom'),
      runtime: lambda.Runtime.NODEJS_10_X,
      timeout: 901
    });

SQS on the other hand validates the props that are set (which contain a token) and it's erroring out there

[amwill04]

@shivlaks does that mean with the way token are encoded when using valueAsNumber it means we lose the ability to validate at synthesis? As the example you provide shows?