Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(synthetics): correct getbucketlocation policy #13573

Merged
merged 5 commits into from
Jan 24, 2022
Merged

fix(synthetics): correct getbucketlocation policy #13573

merged 5 commits into from
Jan 24, 2022

Conversation

csumpter
Copy link
Contributor

When using synthetics runtime "syn-nodejs-puppeteer-3.1" the default role tries to call s3:getBucketLocation on the artifacts bucket, but the policy is incorrect to allow that action.

The policy should allow for that call directly on the bucket arn.

fixes #13572

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

fix(synthetics): correct getbucketlocation policy
5a72897 
When using synthetics runtime "syn-nodejs-puppeteer-3.1" the default role tries to call s3:getBucketLocation on the artifacts bucket, but the policy is incorrect to allow that action.

The policy should allow for that call directly on the bucket arn.

fixes aws#13572
@gitpod-io
Copy link

gitpod-io bot commented Mar 12, 2021

@github-actions github-actions bot added the @aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics label Mar 12, 2021
@NetaNir
Copy link
Contributor

NetaNir commented Mar 17, 2021

I have commented on the issue, lets discuss the fix there.

@NetaNir NetaNir removed their assignment Jun 22, 2021
@kaizencc kaizencc self-assigned this Jan 20, 2022
@gitpod-io
Copy link

gitpod-io bot commented Jan 20, 2022

kaizencc
kaizencc previously approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @csumpter! I've verified that this looks good on my end. Sorry it took so long to get to it!

@csumpter
Copy link
Contributor Author

Thanks for the fix @csumpter! I've verified that this looks good on my end. Sorry it took so long to get to it!

Thank you @kaizen3031593 for the follow-up and approval, really appreciate it.

@mergify mergify bot dismissed kaizencc’s stale review January 21, 2022 19:04

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Jan 24, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 55e349f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e743525 into aws:master Jan 24, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 24, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

LukvonStrom pushed a commit to LukvonStrom/aws-cdk that referenced this pull request Jan 26, 2022
@csumpter @LukvonStrom
fix(synthetics): correct getbucketlocation policy (aws#13573)
dbd5f2f 
When using synthetics runtime "syn-nodejs-puppeteer-3.1" the default role tries to call s3:getBucketLocation on the artifacts bucket, but the policy is incorrect to allow that action.

The policy should allow for that call directly on the bucket arn.

fixes aws#13572


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@wilhen01
Copy link
Contributor

Does anyone know when this will be released? It's not in the changelog for 2.9.0

@kaizencc
Copy link
Contributor

@wilhen01 2.9 corresponds with 1.140 and not with the latest on master. Look out for 1.141 released this week, and then the corresponding 2.10 released the week after.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@csumpter @TikiTDO
fix(synthetics): correct getbucketlocation policy (aws#13573)
37e99a0 
When using synthetics runtime "syn-nodejs-puppeteer-3.1" the default role tries to call s3:getBucketLocation on the artifacts bucket, but the policy is incorrect to allow that action.

The policy should allow for that call directly on the bucket arn.

fixes aws#13572


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc approved these changes

Assignees

@kaizencc kaizencc

Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(synthetics): getbucketlocation policy is incorrect
5 participants
@csumpter @NetaNir @aws-cdk-automation @wilhen01 @kaizencc