Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rds): deploy fails with "SubnetGroup not found" #13986

Merged
merged 4 commits into from
Apr 9, 2021
Merged

fix(rds): deploy fails with "SubnetGroup not found" #13986

merged 4 commits into from
Apr 9, 2021

Commits on Apr 5, 2021

  1. fix(rds): deploy fails with "SubnetGroup not found" 

    As it turns out, RDS stores the name of the SubnetGroup in lowercase on the server-side.
The problem is that we weren't changing the case in CloudFormation,
and thus expressions like `{ Ref: SubnetGroup }` were using the wrong casing,
resulting in the RDS service failing with a 404 error when providing a name for the SubnetGroup.

Fixes aws#13976
    @skinny85
    skinny85 committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    e46c614 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. Merge remote-tracking branch 'origin/master' into fix/rds-subnet-grou… 

    …p-name-lowercase2
    @skinny85
    skinny85 committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    01afe8b View commit details
    Browse the repository at this point in the history

  2. Added check for subnetGroupName being a Token.

    @skinny85
    skinny85 committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    908fef1 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2021

  1. Merge branch 'master' into fix/rds-subnet-group-name-lowercase

    @mergify
    mergify[bot] authored Apr 9, 2021
    Configuration menu
    Copy the full SHA
    275dec1 View commit details
    Browse the repository at this point in the history