chore: add enough information to make package builds cacheable #14341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add build config for a build tool that needs to know about all the dependencies.
…uijbers/nozem-config
|
|
eladb
approved these changes
Apr 23, 2021
rix0rrr
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
john-tipper
pushed a commit
to john-tipper/aws-cdk
that referenced
this pull request
May 10, 2021
…4341) Enhance our `package.json`s with enough information to make hermetic, cacheable builds possible. Mostly consists of: * Adding missing `@types/*` packages to `devDepencendies` everywhere. Those dependencies were always required but undeclared. * Add `nozem.ostools` to various packages to indicate the non-hermetic binaries these scripts depend on. * Add `/// !cdk-integ pragma:ignore-assets` to all integ tests that use assets. * Fix some `.gitignores` that were ignoring files that were already committed inside git. * Update `pkglint` to not be reliant on its *own* location inside the monorepo, but instead search upwards for the monorepo root from the package it's checking. To give this a shot yourself, run: ``` $ npx nozem ``` This is a revival of aws#10039, which is now obsolete. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…4341) Enhance our `package.json`s with enough information to make hermetic, cacheable builds possible. Mostly consists of: * Adding missing `@types/*` packages to `devDepencendies` everywhere. Those dependencies were always required but undeclared. * Add `nozem.ostools` to various packages to indicate the non-hermetic binaries these scripts depend on. * Add `/// !cdk-integ pragma:ignore-assets` to all integ tests that use assets. * Fix some `.gitignores` that were ignoring files that were already committed inside git. * Update `pkglint` to not be reliant on its *own* location inside the monorepo, but instead search upwards for the monorepo root from the package it's checking. To give this a shot yourself, run: ``` $ npx nozem ``` This is a revival of aws#10039, which is now obsolete. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance our
package.jsons with enough information to make hermetic, cacheable builds possible. Mostly consists of:@types/*packages todevDepencendieseverywhere. Those dependencies were always required but undeclared.nozem.ostoolsto various packages to indicate the non-hermetic binaries these scripts depend on./// !cdk-integ pragma:ignore-assetsto all integ tests that use assets..gitignoresthat were ignoring files that were already committed inside git.pkglintto not be reliant on its own location inside the monorepo, but instead search upwards for the monorepo root from the package it's checking.To give this a shot yourself, run:
This is a revival of #10039, which is now obsolete.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license