Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase vm.max_map_count to (hopefully) mitigate OOM errors #16752

Merged
merged 2 commits into from
Oct 1, 2021

Conversation

njlynch
Copy link
Contributor

@njlynch njlynch commented Oct 1, 2021

The vm.max_map_count on our CodeBuild instances is fairly low (65530) compared
to our max threads (1125977). Based on a NodeJS issue troubleshooting thread
(nodejs/help#2809), trying to see if increasing this
value stabilizes our builds.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The vm.max_map_count on our CodeBuild instances is fairly low (65530) compared
to our max threads (1125977). Based on a NodeJS issue troubleshooting thread
(nodejs/help#2809), trying to see if increasing this
value stabilizes our builds.
@njlynch njlynch self-assigned this Oct 1, 2021
@gitpod-io
Copy link

gitpod-io bot commented Oct 1, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 1, 2021
buildspec-pr.yaml Outdated Show resolved Hide resolved
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: e8de17b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b6da2b4 into master Oct 1, 2021
@mergify mergify bot deleted the njlynch/sysctl branch October 1, 2021 11:49
@mergify
Copy link
Contributor

mergify bot commented Oct 1, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

njlynch added a commit that referenced this pull request Oct 1, 2021
This value was reduced as part of troubleshooting of various Node Worker memory
issues. These issues are theorized to have been mitigated by #16752. Our pack
time is currently over 2 hours, compared to 20-30 minutes prior to the set of
changes. By removing this worker count override, we should be able to get back
to normal pack times and speed up the pipeline.
mergify bot pushed a commit that referenced this pull request Oct 1, 2021
This value was reduced as part of troubleshooting of various Node Worker memory
issues. These issues are theorized to have been mitigated by #16752. Our pack
time is currently over 2 hours, compared to 20-30 minutes prior to the set of
changes. By removing this worker count override, we should be able to get back
to normal pack times and speed up the pipeline.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
njlynch added a commit that referenced this pull request Oct 11, 2021
…16752)

The vm.max_map_count on our CodeBuild instances is fairly low (65530) compared
to our max threads (1125977). Based on a NodeJS issue troubleshooting thread
(nodejs/help#2809), trying to see if increasing this
value stabilizes our builds.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
njlynch added a commit that referenced this pull request Oct 11, 2021
This value was reduced as part of troubleshooting of various Node Worker memory
issues. These issues are theorized to have been mitigated by #16752. Our pack
time is currently over 2 hours, compared to 20-30 minutes prior to the set of
changes. By removing this worker count override, we should be able to get back
to normal pack times and speed up the pipeline.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…ws#16752)

The vm.max_map_count on our CodeBuild instances is fairly low (65530) compared
to our max threads (1125977). Based on a NodeJS issue troubleshooting thread
(nodejs/help#2809), trying to see if increasing this
value stabilizes our builds.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
This value was reduced as part of troubleshooting of various Node Worker memory
issues. These issues are theorized to have been mitigated by aws#16752. Our pack
time is currently over 2 hours, compared to 20-30 minutes prior to the set of
changes. By removing this worker count override, we should be able to get back
to normal pack times and speed up the pipeline.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants