feat(apigatewayv2): http api - domain endpoint type, security policy and mTLS

[SmritiVashisth]

Updating the L2 construct for AWS::ApiGatewayV2::DomainName resource to add support for the properties and features that ApiGateway supports. Adding the following properties:

• DomainNameConfigurations : configuration for an API's domain name (CFN equivalent - https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-apigatewayv2-domainname-domainnameconfiguration.html)
• MutualTlsAuthentication: authentication between client and server (CFN equivalent - https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-apigatewayv2-domainname-mutualtlsauthentication.html)

Changes include:

• Code update to support the properties mentioned above
• Unit test changes for existing tests to account for the updated property - certificate. It was present in DomainNameProps as a root level property, but it is supposed to be present as part of DomainNameConfigurations. This is a breaking change for existing customers because their old constructs will be invalid after this change.
• New unit tests for mutual tls that were not present before.

BREAKING CHANGE: Property certificate was present under DomainNameProps earlier and it has been moved to DomainNameConfigurations now, same as CFN. Existing constructs will fail as they'll be invalid now.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[awsperi2]

Testing comments

[awsperi2]

Let's fix RegionallCertificateArn usage here. You can work with our doc writer if needed for a more accurate description

[SmritiVashisth]

ok

[nija-at]

Please find my comments below.

[nija-at]

Suggested change

	* The ARN of the public certificate issued by ACM to validate ownership of your
	* The public certificate issued by ACM to validate ownership of your

[nija-at]

Confusing. RegionalCertificateArn is not here AFAICT. This needs to be written in CDK terms and not just copy-pasted from CFN.

Pull request has been modified.

[SmritiVashisth]

Updating documentation for domain name properties and adding the same in README.

[awsperi2]

some more comments

[SmritiVashisth]

Updated docs.

[nija-at]

Since adding multiple domain name configuration is only during migration, and is not the dominant use case, I suggest changing the API like this -

const domain = new DomainName(stack, 'DomainName', {
   domainName: 'example.com',
   certificate: '...',
   endpointType: '...'
});
domain.addConfiguration({
  certificate: '...',
  endpointType: '...',
  ...
});

This keeps the API clean for the majority of users, while enabling the migration use case.
More importantly, it also avoids an API breaking change.

[nija-at]

Why is this being added?

[nija-at]

Hi @SmritiVashisth - I've just approved this PR that adds mTLS support to HTTP APIs - #17284 - since it was well contained.

Hopefully, that helps you now focus on the domain configuration part.

Pull request has been modified.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: ada1f20
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository